User tests: Successful: Unsuccessful:
Fixes #5312
This PR updates the $contexts array when items are copied and at the same time, the language of the new copy is changed. This assumes that the context of each item is the same... I'm not sure that is always the case and thus someone else has to review this.
Thanks for the bug report @infograf768
Could you provide test instructions?
Labels |
Added:
?
|
Could you quickly test this at your end? If not fixing it, it should at least improve it...
same
I changed this further. If this does not work, I'm really stumped...
... but, with your PR applied, I'm still getting this:
[Sat Dec 06 01:13:14.349446 2014] [:error] [pid 5392:tid 1648] [client 127.0.0.1:49338] PHP Notice: Undefined offset: 91 in D:\\UniServerZ\\vhosts\\smztest\\libraries\\legacy\\model\\admin.php on line 480, referer: http://my.test.smz.it/administrator/index.php?option=com_modules&view=modules
Ok, so I looked into this further and we basically have this bug everywhere where we implemented the batch feature... Please test this now again. I guess I caught all.
@Hackwar Seems to be alright now, Hannes!
While you're into the batch thing, can you look at #5304 "Problem 3"? It is a minor thing and in a way a documented "feature", but IMHO the behavior is at least... "not elegant". In #5304 (comment) I explain what I would expect as a normal behavior.
Thanks!
Category | ⇒ | Administration |
Tested successfully! Thank you @Hackwar for the fix.
2 tests -> RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5317.
Status | Pending | ⇒ | Ready to Commit |
Not RTC yet. The PR works for the components patched
I see the same issue for articles, newfeeds and categories. (When patching the same way in batchCopy () as done for contact in this PR, it solves the issue here.)
Status | Ready to Commit | ⇒ | Pending |
Done. I plan on investing some time into the batch code... There seem to be some more improvements possible, but I will work on that in another PR.
Also tested the other components properly! All occurrences are now considered.
@Hackwar Thank you for the fast reaction.
Now is should be okay to set to RTC! :-)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5317.
Status | Pending | ⇒ | Ready to Commit |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-08 07:15:01 |
Milestone |
Added: |
Test instructions:
Select a module which language is set to "All".
Click on the Batch button.
set the batch params as such:
One will get
[04-Dec-2014 10:48:14 UTC] PHP Notice: Undefined offset: 132 in ROOT/libraries/legacy/model/admin.php on line 477
where "132" is the id of the new module
This PR does NOT solve the issue here.