? Failure

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
4 Dec 2014

Changed the plugin to use the new API:
https://developers.google.com/recaptcha

avatar nonumber nonumber - open - 4 Dec 2014
avatar jissues-bot jissues-bot - change - 4 Dec 2014
Labels Added: ?
avatar nonumber nonumber - change - 4 Dec 2014
The description was changed
avatar infograf768
infograf768 - comment - 4 Dec 2014

Tested with existing captcha on legacy site
I get an error:
"ERROR: Global site keys are not supported"

avatar Bakual
Bakual - comment - 4 Dec 2014

We decided to leave old language strings in (with a deprecated notice) even if they are not used anymore.

Reason is to reduce possible problems with updated language packs and extensions using strings from core extensions. So please don't remove them. You can add a comment before them stating that they're deprecated and no longer used.

avatar nonumber
nonumber - comment - 4 Dec 2014

@infograph: What do you mean with "existing captcha"? What do you mean with "legacy site"?

avatar infograf768
infograf768 - comment - 4 Dec 2014

The new API is not B/C with Global Keys.
If we force this update as is, sites may not be B/C.

Maybe we could create a new plugin specially for that Captcha2 ?

avatar infograf768
infograf768 - comment - 4 Dec 2014

@nonumber
I mean what I said above: when updating with this PR, my keys are not working anymore as they are Global Keys, this the error

avatar nonumber
nonumber - comment - 4 Dec 2014

@Bakual : Ok, placed them back.

avatar nonumber
nonumber - comment - 4 Dec 2014

@infograf768: Sorry, have no idea what "Gloabal Keys" you are talking about. Are you placing a Captcha via some custom code or something?

avatar infograf768
infograf768 - comment - 4 Dec 2014

See:
https://code.google.com/p/recaptcha/wiki/HowToSetUpRecaptcha

The keys are unique to your domain and sub-domains and will not work for other domains unless you:

Sign up for multiple keys (one for each site)
Create a global key by checking the box for "Enable this key on all domains (global key)"

For example:

The keys for test.com will work on a.test.com, b.test.com, c.test.com and any other sub-domains.
If the option "Enable this key on all domains (global key)" is checked, the keys will work on a.test.com, x.com, y.com and any other domains or sub-domains.

avatar infograf768
infograf768 - comment - 4 Dec 2014

What I am saying is that I get an error because the new API does NOT accept global Keys.
Google itself tells it (but sorry, I just found it in French)

avatar Bakual
Bakual - comment - 4 Dec 2014

As I understand it, this new captcha doesn't work with the old parameters (keys) set. So we would indeed have to deprecate the old plugin and create a new one.
Or add a mode to the plugin which allows to either use the old or new API.

It may also useful to have a postinstall message telling the user to update the plugin. The message could even be only shown if the old plugin/mode is enabled.

avatar infograf768
infograf768 - comment - 4 Dec 2014

Here is the Google info (in French):
screen shot 2014-12-04 at 11 21 39

avatar infograf768
infograf768 - comment - 4 Dec 2014

I think it would be better to create a totally new plugin.

avatar brianteeman
brianteeman - comment - 4 Dec 2014

Made some comments about the use of public and private key in the language strings

avatar brianteeman
brianteeman - comment - 4 Dec 2014

It may also useful to have a postinstall message telling the user to update the plugin. The message could even be only shown if the old plugin/mode is enabled.

Will both methods co-exist or is the new one replacing the old one at some time.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5315.

avatar nonumber
nonumber - comment - 4 Dec 2014

I don't have the time to re-write this so that it is a new plugin or supports both the old and new API.
So if anyone wants to fork this , then please go ahead.

avatar nikosdion
nikosdion - comment - 4 Dec 2014

I think that this should be a new plugin. Moreover, we should fork the ReCaptchaResponse class under a new name, e.g. JReCaptchaResponse. Third party extensions are already using this class (I've seen it before, I can't remember where for the life of me). If we ship it with Joomla! undermanned we will break 3PD extensions.

If Peter has no time to do that, would you like me to handle it?

avatar brianteeman
brianteeman - comment - 4 Dec 2014

A new plugin called NoCaptcha would make the most sense to me. If the API
keys hadnt changed it could have just been an update but with the changed
keys that would break peoples web sites

On 4 December 2014 at 12:35, Nicholas K. Dionysopoulos <
notifications@github.com> wrote:

I think that this should be a new plugin. Moreover, we should fork the
ReCaptchaResponse class under a new name, e.g. JReCaptchaResponse. Third
party extensions are already using this class (I've seen it before, I can't
remember where for the life of me). If we ship it with Joomla!
undermanned we will break 3PD extensions.

If Peter has no time to do that, would you like me to handle it?


Reply to this email directly or view it on GitHub
#5315 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar nikosdion
nikosdion - comment - 4 Dec 2014

I have forked the plugin. Please see gh-5323.

avatar nonumber
nonumber - comment - 4 Dec 2014

Ok, great. So this one is closed.
Thanks for taking this over.

avatar nonumber nonumber - close - 4 Dec 2014
avatar nonumber nonumber - change - 4 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-04 14:51:57

Add a Comment

Login with GitHub to post a comment