? Success

User tests: Successful: Unsuccessful:

avatar smanzi
smanzi
3 Dec 2014

It was impossible to drag modules to change their order. This fixes it.
A copy-paste mishap, I think...

avatar smanzi smanzi - open - 3 Dec 2014
avatar jissues-bot jissues-bot - change - 3 Dec 2014
Labels Added: ?
avatar dgt41
dgt41 - comment - 3 Dec 2014

@test success

avatar smanzi
smanzi - comment - 3 Dec 2014

tnx @dgt41!

avatar dgt41 dgt41 - test_item - 3 Dec 2014 - Tested successfully
avatar smanzi
smanzi - comment - 4 Dec 2014

When I find something that was previously working and suddenly is broken, I feel the urge to understand the reasons why the thing broke. I felt the same urge for this bug.

Apparently somebody made a mistake and made a reference to a table using the id="articleList" while the correct id of the table is "moduleList" (which makes sense as we are in com_modules).

The first thing I thought is that it was a case of copy-paste gone ill: someone edited code for com_content and then copy-pasted the same code here forgetting to modify articleList in moduleList.

The strange thing is that the involved line comes directly from a commit made in august 2012...

Then... it must be the other way around... the id must had been changed in the table itself... YES, bingo!

It all comes from PR #4956, where the coder made an extensive review of the HTML code of several views (19 files in total are affected) and at the same time decided to give more sensible IDs to several items (which by itself is not a bad thing). Sin that he had forgotten to modify references to the modified IDs!!

So far I've been able to identify that plugin manager too is affected by the same issue: try to drag plugins up and down, it will not work.

I'm going to add a commit fixing com_plugins and then check if any other views are affected, so for the time being please don't merge this PR: I think it will takes a couples of days to be reasonably sure that everything is OK...

I'm also wondering if it is better to continue modifing the references to the modified IDs or revert the IDs to their original names, although less appropriate ones...

To the attention of the usual mergers: @infograf768, @bakual, @brianteeman, @roland-d (sorry if I'm forgetting someone...)

avatar smanzi
smanzi - comment - 4 Dec 2014

As far as regards draggable lists it should be OK...

I'll check if there is anything else...

avatar infograf768
infograf768 - comment - 4 Dec 2014

Good find!
test works fine for me. Obvious bug solved. Merging.

avatar infograf768 infograf768 - close - 4 Dec 2014
avatar infograf768 infograf768 - change - 4 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-04 06:20:24
avatar smanzi
smanzi - comment - 4 Dec 2014

@infograf768 JM, you sure there isn't anything else wrong in that PR? It is quite massive, with a lot of code moved to the right by one tab, and thus difficult to compare with the original...

Add a Comment

Login with GitHub to post a comment