Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5295] - Routing: Discover Itemid in Router for com_newsfeeds

? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
2 Dec 2014

This change moves the code that discovers the right Itemid for this content item from the NewsfeedsHelperRoute class into the component router. This means that also URLs in the content get the right Itemid and we don't need to pre-calculate them during the time the item was created. It also means that all URLs are treated correctly and not just those going through NewsfeedsHelperRoute.

This makes NewsfeedsHelperRoute obsolete. The changes that I'm proposing might interfer with PR #5140. So #5140 should be merged first in order to test this one properly. That means that also #5264 and #5276 should be merged before this one.

This touches com_newsfeeds. Further components are done in other PRs. I also wanted to keep it testable, since no one could be expected to test all components at once. See the first PR for this in #5285.

This was made possible through the generous donation of the people mentioned in the following link via an Indiegogo campaign: http://joomlager.de/crowdfunding/5-contributors

avatar Hackwar Hackwar - open - 2 Dec 2014
avatar jissues-bot jissues-bot - change - 2 Dec 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 3 Dec 2014
Category ⇒ SEF
avatar johanjanssens
johanjanssens - comment - 3 Dec 2014

See my comments on #5285 (comment)

avatar Hackwar
Hackwar - comment - 30 Dec 2014

Since this is now superseded by #5444, #5446 and #5503, I'm closing this one.

avatar Hackwar Hackwar - close - 30 Dec 2014
avatar Hackwar Hackwar - close - 30 Dec 2014
avatar Hackwar Hackwar - change - 30 Dec 2014
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-12-30 10:03:54
avatar Hackwar Hackwar - head_ref_deleted - 30 Dec 2014

Add a Comment

Login with GitHub to post a comment