What is the best way to test this?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5271.

The PR would first have to be updated to staging

@sanderpotjer In a discussion related to another PR I wondered what the difference is between

• having no asset entry (asset_id = 0)
• having an asset entry with no rules stored ({})
• having an asset entry with rules lie {"core.delete":[],"core.edit":[],"core.edit.state":[]}

Imho they should actually all work the same, using default settings from the component or global. Or not?

@Bakual if the information is missing it will indeed try to look for the permissions of parent item (e.g. component), if that is missing it will search for the global configuration permission settings.

So the main reason to provide the correct information as quickly as possible is performance wise, no need to look for parents settings.

@infograf768 thats always the downside of doing pull request for the sample data...

@sanderpotjer Thanks!

@sanderpotjer Following the conversation I am not sure if this is ready for testing or an update is needed.

@sanderpotjer It is unclear from comments above if this has been updated as requested by @infograf768

I tried to improve the asset sample data multiple times now, each time it is "outdated" soon due other changes. Without proper planning to review and commit it in a short timeframe I won't spend my time for another attempt...

In this case it was left by most testers because of the lack of any test
instructions

Experience here on the tracker shows that all pull requests that are
accompanied with clear test instructions get tested very very quickly

On 16 June 2015 at 21:01, Sander Potjer notifications@github.com wrote:

I tried to improve the asset sample data multiple times now, each time it
is "outdated" soon due other changes. Without proper planning to review and
commit it in a short timeframe I won't spend my time for another attempt...

—
Reply to this email directly or view it on GitHub
#5271 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

My experience here on the tracker is that correcting sample data is a nightmare, even with testing instructions. On top of that asset sample data is hardly testable via the Joomla interface (so not with the Patch Tester), just have a look at the file changes yourself.

Truthfully, I consider the sample data a lost cause. If you can get the core joomla.sql files updated (and they should be in sync for all the DB drivers), that's usually enough for someone who decently comprehends the different schemas to go with. Those who are able to clone a patch with git or download a branch's ZIP will test it, but that audience is admittedly a lot smaller than those who work with the patch tester.

My experience here on the tracker is that correcting sample data is a nightmare, even with testing instructions.

hmm the easiest is to give the test instructions like this:

• Install my branche as normal joomla install see: https://github.com/sanderpotjer/joomla-cms/archive/staging.zip
• confirm that the installation still works
• confirm that all sample data still works
• if all works report a successful test

@zero-24 yeah, two successful tests guaranteed in no-time. But I think its better if its reviewed by people that know a bit more about the sample data and its structure to have some quality control, right?

But I think its better if its reviewed by people that know a bit more about the sample data and its structure to have some quality control, right?

@sanderpotjer
Agree but I think a review / quality control is anytime bevor the merge. And I think the committers know a bit more about the sample data

I am setting this to review to discuss within the PLT what to do with the sample data.

@rdeutz has volunteered to help clean up the sample data. So we can move this forward and get it merged. @sanderpotjer please let us know if you have still have interest in helping Robert. Thanks.

Thank you all for your work. I am going to close it as this PR is now out-of-date. If anybody is interested in maintaining the sample data, please contact me and we will get you going.