? Success

User tests: Successful: Unsuccessful:

avatar smanzi
smanzi
29 Nov 2014

As we often do not load MooTools for our own needs, here we force the loading of it for B/C with 3rd party extensions back-end

avatar smanzi smanzi - open - 29 Nov 2014
avatar jissues-bot jissues-bot - change - 29 Nov 2014
Labels Added: ?
avatar smanzi
smanzi - comment - 29 Nov 2014

This fixes (amongst other possible situations) the issue raised in #5239

avatar phproberto
phproberto - comment - 29 Nov 2014

Why should we load Mootools everywhere??

In fact this would cause serious B/C issues for extensions nos using Mootools.

avatar smanzi
smanzi - comment - 29 Nov 2014

@phproberto Actually I'm of the "this is not a B/C issue" school, but in case, how can we know if a 3rd party extension is relying on MooTools? Why do you think this will break other extensions?

avatar mbabker
mbabker - comment - 29 Nov 2014

There are only a handful of places in core that would need to load Mootools to support extensions. com_installer is one of them. IMO, there's no need to load it as part of both templates.

avatar infograf768
infograf768 - comment - 29 Nov 2014

Agree with loading in com_installer indeed

avatar smanzi
smanzi - comment - 29 Nov 2014

@mbabker Agreed.... this was only to keep "on the safe side of things" and I think it would cause big performance isssues, once MooTools is cached locally, unless @phproberto is right and this is causing other B/C issues...

avatar dgt41
dgt41 - comment - 29 Nov 2014

We can load mootools in layout/toolbar/base which covers most cases and is also overridable. Sorry NO to this one!

avatar smanzi
smanzi - comment - 29 Nov 2014

OK, got it! closing this! :smiley:

avatar smanzi smanzi - close - 29 Nov 2014
avatar smanzi smanzi - close - 29 Nov 2014
avatar smanzi smanzi - change - 29 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-29 16:57:21
avatar smanzi smanzi - head_ref_deleted - 4 Dec 2014

Add a Comment

Login with GitHub to post a comment