User tests: Successful: Unsuccessful:
Introduce formvalidator
Use native selector instead of document.id
Inline scripts added through API addScriptDeclaration
Use template.js from @AshanFernando PR #2003 which is not mootools dependent
Labels |
Added:
?
|
Labels |
Added:
?
|
Patch takes off the js error indeed (Timestamp: 29/11/14 12:11:03
Error: TypeError: window.addEvent is not a function
Source File: http://localhost:8888/trunkgitnew/administrator/templates/hathor/js/template.js?d179210de85b432dae57c6da7af86f06
Line: 102).
Although here it does not prevent functionnality
I guess it is better if we don’t cause any errors?
But maybe the template.js is prone to errors:
[Error] TypeError: null is not an object (evaluating 'target.href = "#skiptarget"')
setSkip (template.js, line 28)
(anonymous function) (template.js, line 129)
(anonymous function) (mootools-core.js, line 121)
forEach ([native code], line 0)
(anonymous function) (mootools-core.js, line 5)
each (mootools-core.js, line 9)
fireEvent (mootools-core.js, line 120)
j (mootools-core.js, line 175)
Update: I used the code from #2003 for template.js, since @AshanFernando has done an excellent job there and converted it to jquery!
Also I converted all JHtml('behavior.formvalidation');
to JHtml('behavior.formvalidator');
And removed the inline scripts and add them through the API (addScriptDeclaration())
Title |
|
Title |
|
Category | ⇒ | Templates (admin) |
I ran through all the menu areas, users, components, ect. and everything worked fine after i applied the patch
Tested this by setting the Hathor template to default.
Went through all the diferrent views in the administration area, tried clicking the save, save & close, close etc buttons to see if they are still working.
Also checked the console in the browser to make sure there were no JS conflicts
Status | Pending | ⇒ | Ready to Commit |
RTC based on testing #jab15 #makeithappen
Labels |
Added:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-30 23:19:18 |
Closed_By | ⇒ | wilsonge |
Merged - thanks!
thanks!
Milestone |
Added: |
Labels |
Removed:
?
|
@infograf768 Please take a look here!