? Success
Referenced as Related to: # 5240 # 5241

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
29 Nov 2014

Reduce mootools

Introduce formvalidator
Use native selector instead of document.id
Inline scripts added through API addScriptDeclaration

Use template.js from @AshanFernando PR #2003 which is not mootools dependent

avatar dgt41 dgt41 - open - 29 Nov 2014
avatar jissues-bot jissues-bot - change - 29 Nov 2014
Labels Added: ?
avatar jissues-bot jissues-bot - change - 29 Nov 2014
Labels Added: ?
avatar dgt41
dgt41 - comment - 29 Nov 2014

@infograf768 Please take a look here!

avatar dgt41 dgt41 - change - 29 Nov 2014
The description was changed
avatar infograf768
infograf768 - comment - 29 Nov 2014

Patch takes off the js error indeed (Timestamp: 29/11/14 12:11:03
Error: TypeError: window.addEvent is not a function
Source File: http://localhost:8888/trunkgitnew/administrator/templates/hathor/js/template.js?d179210de85b432dae57c6da7af86f06
Line: 102).

Although here it does not prevent functionnality

avatar dgt41
dgt41 - comment - 29 Nov 2014

I guess it is better if we don’t cause any errors?
But maybe the template.js is prone to errors:

[Error] TypeError: null is not an object (evaluating 'target.href = "#skiptarget"')
    setSkip (template.js, line 28)
    (anonymous function) (template.js, line 129)
    (anonymous function) (mootools-core.js, line 121)
    forEach ([native code], line 0)
    (anonymous function) (mootools-core.js, line 5)
    each (mootools-core.js, line 9)
    fireEvent (mootools-core.js, line 120)
    j (mootools-core.js, line 175)
avatar 810
810 - comment - 29 Nov 2014
avatar dgt41
dgt41 - comment - 6 Feb 2015

Update: I used the code from #2003 for template.js, since @AshanFernando has done an excellent job there and converted it to jquery!
Also I converted all JHtml('behavior.formvalidation'); to JHtml('behavior.formvalidator');
And removed the inline scripts and add them through the API (addScriptDeclaration())

avatar dgt41 dgt41 - change - 6 Feb 2015
Title
Hathor needs mootools for menu accessibility
Hathor: reduce mootools dependency
avatar dgt41 dgt41 - change - 6 Feb 2015
The description was changed
Title
Hathor needs mootools for menu accessibility
Hathor: reduce mootools dependency
avatar dgt41 dgt41 - change - 6 Feb 2015
The description was changed
avatar brianteeman brianteeman - change - 22 May 2015
Category Templates (admin)
avatar hanshenrikchr hanshenrikchr - test_item - 30 May 2015 - Tested successfully
avatar hanshenrikchr
hanshenrikchr - comment - 30 May 2015

I ran through all the menu areas, users, components, ect. and everything worked fine after i applied the patch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5245.

avatar superfoght
superfoght - comment - 30 May 2015

Tested this by setting the Hathor template to default.

Went through all the diferrent views in the administration area, tried clicking the save, save & close, close etc buttons to see if they are still working.

Also checked the console in the browser to make sure there were no JS conflicts


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5245.

avatar superfoght superfoght - test_item - 30 May 2015 - Tested successfully
avatar zero-24 zero-24 - change - 30 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 30 May 2015

RTC based on testing :smile: #jab15 #makeithappen


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5245.

avatar zero-24 zero-24 - change - 30 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 30 May 2015
Labels Added: ?
avatar dgt41
dgt41 - comment - 30 May 2015

@wilsonge can you merge this?

avatar zero-24 zero-24 - close - 30 May 2015
avatar wilsonge wilsonge - change - 30 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-30 23:19:18
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 May 2015
avatar wilsonge wilsonge - close - 30 May 2015
avatar wilsonge
wilsonge - comment - 30 May 2015

Merged - thanks!

avatar AshanFernando
AshanFernando - comment - 31 May 2015

thanks!

avatar dgt41 dgt41 - head_ref_deleted - 31 May 2015
avatar zero-24 zero-24 - change - 31 May 2015
Milestone Added:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment