? Error

User tests: Successful: Unsuccessful:

avatar torxt
torxt
28 Nov 2014

jform note got a (optional)

avatar torxt torxt - open - 28 Nov 2014
avatar jissues-bot jissues-bot - change - 28 Nov 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 28 Nov 2014

Please create your PRs against the staging branch and explain at least by screenshots what happens and what will be after patching

avatar sovainfo
sovainfo - comment - 28 Nov 2014

Considering I found out might as well add it here:
This PR fixes the BUG in User Registration attaching a (optional) when inappropriate.
Currently this label shows for fields that require optional input. It adds the fields of type 'note' to be excluded from receiving this label as it doesn't require input.

The field type 'Note' is a core field type but not used in core User Registration. To test this I activated the User - Profile plugin and changed the field "aboutme" to type 'note'.
The "(optional)" gets attached which is undesired. After applying this PR there is no "(optional)" on the readme field anymore.

@test OK, Bug reproduced and PR fixes it.

avatar infograf768
infograf768 - comment - 28 Nov 2014

As you said: Note is not used in Core User registration.
Therefore, one would have to hack core or create one's own plugin for profile to get such a field to display.
I fail to understand why we would have to cope with that in core.

avatar Bakual
Bakual - comment - 28 Nov 2014

Closing as it is against an EOL branch and will not be considered anyway.

Feel free to open one against staging if you feel it needs to be fixed in Joomla 3.3.x

Looking at the code, I'm not a huge fan of having field specific code in the layout. That always smells a bit hackish to me.

avatar Bakual Bakual - close - 28 Nov 2014
avatar Bakual Bakual - change - 28 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-28 15:05:17

Add a Comment

Login with GitHub to post a comment