[#5232] - CodeMirror 4.8
- Closed
- 6 Dec 2014
- Medium
- Build: staging
- # 5232
- Diff
- okonomiyaki3000:UpdateCodeMirror
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Because there seems to be something wrong over at #5145
jissues-bot
- | Labels |
Added:
?
|
||
I have checked and the build is still in queue in Travis, I think we need to wait a bit to get reply.
brianteeman
- | Category | ⇒ | External Library |
It's working OK here.
Not sure about changing the original html files to empty ones.
It's fine. They are just examples. Totally unneeded for using CodeMirror. I'm already making several modifications to the distro anyway. Like concatenation and minifying the addons. So it's not like /media/editors/codemirror was ever a straight copy of their distro.
If they are no use, I would just delete them. This is part of the general move to delete the index.html files in J!
Ah! I wasn't aware there was such a movement. I can definitely remove them.
@test it works still good here thanks @okonomiyaki3000
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5232.
| Status | Pending | ⇒ | Ready to Commit |
movint to RTC as we have 2 good tests thanks @okonomiyaki3000
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5232.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-06 08:04:44 |
| Labels |
Removed:
?
|
||
I think something went wrong with Travis.