@test works

There was a reason why iframe and not RSS was chosen originally but I
forget why
On 27 Nov 2014 13:49, "waader" notifications@github.com wrote:

@test https://github.com/test works

—
Reply to this email directly or view it on GitHub
#5222 (comment).

We did discuss briging back the RSS feed for the cpanel in the JUX team. The biggest problem with it was at the time it wasnt very graceful when it couldnt connect (ie during local development) but I guess without that there wouldnt be issues

@brianteeman that’s your quote from here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=31977

@brianteeman Trying the view without internet, gracefully renders a message “Feed not found”, so I guess this is not a problem anymore…

How long did it take. There used to be a long wait before you got it which
caused issues BUT it was also on the hone page of the admin so more
noticeable then
On 27 Nov 2014 14:30, "Dimitris Grammatiko" notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman Trying the view without
internet, gracefully renders a message “Feed not found”, so I guess this is
not a problem anymore…

[image: screen shot 2014-11-27 at 4 28 29]
https://cloud.githubusercontent.com/assets/3889375/5218206/b2ec2730-7652-11e4-820e-ba79aee0eb7c.png

—
Reply to this email directly or view it on GitHub
#5222 (comment).

@brianteeman under a sec to load locally:

sounds ok then - it used to be a loooong time

On 27 November 2014 at 14:37, Dimitris Grammatiko notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman under a sec to load locally:

[image: screen shot 2014-11-27 at 4 35 29]
https://cloud.githubusercontent.com/assets/3889375/5218277/a0f19316-7653-11e4-91b0-a99dba0ccc48.png

—
Reply to this email directly or view it on GitHub
#5222 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

All good. Load time is fine :)

Thanks for the PR.
Just thinking loud: Would it make sense to make that a real module instead of hardcoding it in? Like you just load a custom moduleposition postinstall and there is a regular mod_feed module set up which displays in that position (we can do that using SQL queries.
That way it would be customisable by the user. If any issues arise with loading time or if the user doesn't want that feed, the module could simply be deactivated.

I am pretty sure that is why we have an rss module in a position
postinstall in the sample data

On 27 November 2014 at 15:12, Thomas Hunziker notifications@github.com
wrote:

Thanks for the PR.
Just thinking loud: Would it make sense to make that a real module instead
of hardcoding it in? Like you just load a custom moduleposition
postinstall and there is a regular mod_feed module set up which displays
in that position (we can do that using SQL queries.
That way it would be customisable by the user. If any issues arise with
loading time or if the user doesn't want that feed, the module could simply
be deactivated.

—
Reply to this email directly or view it on GitHub
#5222 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Bakual I can push the changes in the default.php, but changing the sql files is not something I did before, and most probably I will ruin everything there ????

@dgt41

but changing the sql files is not something I did before

Example for mysql
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/sample_blog.sql#L143

Example for PostgreSQL
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/postgresql/sample_blog.sql#L164

Example for sqlazure
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/sqlazure/sample_blog.sql#L184

This querys need too be added to the "joomla.sql" files (please have a look into the IDs!) at the point where we add the modules. IIRC this is enough

@zero-24 what about sample_blog, sample_brochure, sample_learn and sample_testing ? these needs the extra line?

@dgt41 yes you are right.

Because of this lines a the sample data files:
TRUNCATE `#__modules`;
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/sample_testing.sql#L12

hmm and we need to addd them to the updates: https://github.com/joomla/joomla-cms/tree/staging/administrator/components/com_admin/sql/updates

looks good to me

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5222.

@test: Tested successfully. Looks good

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5222.

@Bakual
Is it worth going over all the changes in the sql files, just to be able to customise/disable that module?
We already can add a feed module in CPanel, if desired.
This PR works fine here too.

(my 4 cents)

Not necessary. I just think it would be better code. I generally don't like hardcoded stuff like this in a layout.
But we can always do that in a later PR even after 3.4.0 is out.

Moving to RTC as we have 2 successful tests.

Turning this into a real module can be a separate PR.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5222.