[#5216] - We're not able to translate language, template and library package names
- Closed
- 29 Nov 2014
- Medium
- Build: master
- # 5216
Today I run into an issue with my template. Apparently when you have a space or special characters in the name of the template (like in my case "{LESS} Allrounder") the copy of the template in the template manager fails without any error. I found the cause of this and while I think that's a bug in itself I wanted to fix it on my side.
Should be easy by using "lessallrounder" as name in the XML which then would be translated to my "{LESS} Allrounder" in the extension manager.
This works fine for other extensions so I really wondered why it didn't work.
The cause is this line:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/models/extension.php#L179
if (!in_array($item->type, array('language', 'template', 'library')))
{
$item->name = JText::_($item->name);
}
settype($item->description, 'string');
if (!in_array($item->type, array('language')))
{
$item->description = JText::_($item->description);
}
I wonder if there is a reason we don't allow to translate language, template and library names and the language description. Someone knows?
jissues-bot
- | Labels |
Added:
?
|
||
I will leave to @infograf768 but I do remember reading an explanation from him a few months back #2796
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5216.
The reason we do not translate template or libraries names is related to the copyright of their authors.
Same as for Joomla! which should NOT be transliterated. (In this last case, we admit a transliteration on a site, IF the right ™ is used at least once in an obvious way on the home page)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5216.
makes sense to me - closed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5216.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-29 17:26:56 |
I don't think I agree. The same reason could be said for any extension, but we allow to translate the name of components, modules and plugins. At least templates are also a regular extension like the others. The translations come from the template provider anyway, so I don't see a reason to restrict him here.
Libraries may be a bit different.
I found the JC item which introduced that check
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=26502
That's back in 2011, committed with 879de61.
@infograf768 You remember the reason for that? Seems strange to not translate stuff just because there is no translation. The fix should be to add the translations, or not?