? Success

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
25 Nov 2014

there is no line between the option to show/hide featured articles and the amount of articles to show in this module.
Without the line people (read: me) can read it as: How many featured articles can be shown. Therefor I was looking for the field to set the amount of other articles I can show.

With the line between the option show/hide featured articles and the field amount people (read: me) have better understanding of the meaning of amount.

avatar hans2103 hans2103 - open - 25 Nov 2014
avatar jissues-bot jissues-bot - change - 25 Nov 2014
Labels Added: ?
avatar brianteeman
brianteeman - comment - 25 Nov 2014

This refers to mod_articles_category

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5199.

avatar brianteeman
brianteeman - comment - 25 Nov 2014

Before

screen shot 2014-11-25 at 07 58 41

After

screen shot 2014-11-25 at 07 58 58

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5199.

avatar brianteeman
brianteeman - comment - 25 Nov 2014

Personally I didnt have the problem that @hans2103 did ut I see no reason not to apply this change

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5199.

avatar brianteeman brianteeman - test_item - 25 Nov 2014 - Tested successfully
avatar sovainfo
sovainfo - comment - 25 Nov 2014

Don't like wasting even more space. Maybe swapping them improves understanding.

avatar smanzi
smanzi - comment - 25 Nov 2014

@sovainfo :+1:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5199.

avatar infograf768
infograf768 - comment - 26 Nov 2014

OK here too for swapping instead of this.

avatar brianteeman
brianteeman - comment - 26 Nov 2014

Dont really care which solution is chosen but as the consensus appears to be for simply just swapping the two fields around and not having the separator line @hans2103 can you update your PR for that and then it can be committed

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5199.

avatar hans2103
hans2103 - comment - 26 Nov 2014

I agree on the suggestion to swap the fields instead of adding an extra element.
therefor I've changed the pull request.

avatar smanzi
smanzi - comment - 26 Nov 2014

@test success

avatar smanzi smanzi - test_item - 26 Nov 2014 - Tested successfully
avatar smanzi
smanzi - comment - 26 Nov 2014

Probably unimportant if this is quickly merged, but the PR title is now out-of-sync with nature of the changes...

avatar smanzi
smanzi - comment - 26 Nov 2014

Wait... while you are there, it seem there is a useless double separator further down:
capture-1
You could get rid of it and, leaving the "Count" at the top, reinstate a sparator below it, to keep the "Filter on Featured" option grouped by itself as all others below are...
capture2

You decide! :smile:

avatar hans2103
hans2103 - comment - 26 Nov 2014

@smanzi Between those two lines the fields "author_filtering_type" and "created_by" should be present.

avatar infograf768
infograf768 - comment - 26 Nov 2014

@hans2103
It is just a matter of deleting:

                <field
                    name="filteringspacer6"
                    type="spacer"
                    hr="true" />
avatar hans2103 hans2103 - change - 26 Nov 2014
Title
add a line between two options for better UI
swap two options for better UI
avatar hans2103
hans2103 - comment - 26 Nov 2014

I wanted to create a new pull request to remove the obsolete separator line.
It seems that it is merged into this one.

avatar infograf768
infograf768 - comment - 26 Nov 2014

It's ok.

avatar smanzi
smanzi - comment - 26 Nov 2014

@test confirmed after latest commit

avatar infograf768 infograf768 - close - 27 Nov 2014
avatar infograf768 infograf768 - change - 27 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-27 05:40:37

Add a Comment

Login with GitHub to post a comment