Works for me with both test and no sample data

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5186.

@test success

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5186.

Two good tests setting to RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5186.

@waader You can't do it this way with the update SQL files.
Those will only have an effect for people updating from 3.2.1 and 3.3.3 respectively. If you want to fix it for all updating users, you need to create a new file 3.4.0-2014-12-03.sql where you fix the schema.

Can you update the PR and add the SQL into this new file?

@bakual I played around with the update mechanism and from my expierences I have to do it that way otherwise you will always have entries like "Table 'd9pth_user_profiles' does not have column 'profile_value' with type TEXT" on the database tab even when I would have this new file.

But what I should do additionally is creating that new file. it would be easier for me - at the moment - if you could merge this and I would provide an additional patch.

@waader Have you already created the additional patch? Just want to be sure all users can update.

@waader can we have that other PR please. I want all this ready to ship in beta 2 (one week today)

@waader @wilsonge Just want to poke you guys so this isn't forgotten.

@roland-d

I made an update file with this two line:
CREATE INDEX "#__contentitem_tag_map_idx_tag_name" ON "#__contentitem_tag_map" ("tag_id", "type_alias");
ALTER TABLE "#__associations" ALTER COLUMN "id" TYPE int;

But before I applied that file I took an old joomla installation 3.1.1. and updated it to 3.2.7. From there I updated to 3.4.0-beta3 and looked up the database schema. Too my surprise the index was present and the column was of type integer. All without applying my update file. When I go to the extension manager -> database I get the message "Database table structure is up to date".

Maybe there where changes in later version but then my update file could cause problems with versions prior to that changes.

So I don´t know what there should be done.

@waader Apologies for my late reply but if all is working as should I think there is nothing else to be done.Thanks.