[#5171] - Fixes Author and Copyright info for Editor - None
- Closed
- 23 Nov 2014
- Medium
- Build: staging
- # 5171
- Diff
- smz:EditorNoneCopyright
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Just a tiny cosmetic fix:
I do not know if this is wanted for political or legal reasons, but in Extensions Manager, Editor - None is listed as having an "Unknown" author.
I fixed this by adding the required info in none.xml
There is an inconsistency, anyway: the "Creation Date" is set as "August 2004", while the standard Copyright notice says "2005 -2014"
jissues-bot
- | Labels |
Added:
?
|
||
@smanzi good find. I think there is a theoretic way to test :D
- see plugin editor none
- apply patch
- refresh manifest data
- see plugin editor none
Bevor the patch
After the patch
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5171.
There is an inconsistency, anyway: the "Creation Date" is set as "August 2004", while the standard Copyright notice says "2005 -2014"
Confirmed. I think the comitter can have a look into it.
It probably originated with Mambo.
@chrisdavenport so the author tag needs to go to Mambo?
No, I think it's probably safe to keep the author as Joomla. The code will have changed because Joomla uses plugins whereas in Mambo it would have been a "mambot". I was just speculating on why the creation date predates Joomla. A better fix might be to alter the creation date to when Joomla 1.0.0 was released.
A better fix might be to alter the creation date to when Joomla 1.0.0 was released.
So we should use September 2005 instead of August 2004
Yes.
thanks @chrisdavenport
So @smanzi can you add this in to your PR?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-23 13:08:51 |
Good catch. Thanks!
| Milestone |
Added: |
||
I think this untestable with com_patchtester, but there shouldn't be any possibility of bug, I guess.
If there is no legal objection I think this can be merged...