?
Referenced as Pull Request for: # 5170

User tests: Successful: Unsuccessful:

avatar codeling
codeling
22 Nov 2014

This is to fix superfluous log messages in custom logs. It adds categories to those JLog::add calls where there was no category specified yet.

Short history (tl;dr: skip this paragraph): For my own extension, I wanted to create a separate logfile.
For that reason, I called the addLogger function just as described here: http://docs.joomla.org/Using_JLog. I noticed however that some unrelated messages were cropping up from time to time in the extension's log files ("FinderIndexerAdapter::getTypeId", "Can't identify browser version. [..]"); that was even though I had specified my extension's name as category. Looking through the core code, I realized this was due to those error messages not having assigned a category. That's why I've prepared this pull request for Joomla.

This is my first pull request for Joomla, so please point me in the right direction if there's anything amiss; I've already signed the contributor's agreement (my name is Bernhard Fröhler).

I hope I have chosen the correct branch to base this on - not sure about the branching strategy of Joomla? Are such fixes supposed to go into staging/master first maybe? Problem is some things ("Can't identify browser") were already removed there. And which branches would this need to be merged in addition? I suppose 3.4-dev? Thanks in advance for your patience with a newbie...

avatar codeling codeling - open - 22 Nov 2014
avatar jissues-bot jissues-bot - change - 22 Nov 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 22 Nov 2014

Have a look here: https://github.com/joomla/joomla-cms/blob/staging/CONTRIBUTING.md#branches

Most Pull Requests should be targeted against the staging branch.
Your current PR is against the 2.5.x branch, which would mean it's for Joomla 2.5. Honestly speaking, there is no point doing PRs for that branch anymore since it will be end of life in a month. So only very important fixes will be merged.

I'm closing this PR since it will not be merged anyway. Try to do one for staging if it's still an issue in Joomla 3.x

avatar Bakual Bakual - close - 22 Nov 2014
avatar Bakual Bakual - change - 22 Nov 2014
The description was changed
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-22 19:01:12

Add a Comment

Login with GitHub to post a comment