[#5135] - Initial codereview of languagefilter plugin
- Closed
- 20 Nov 2014
- Medium
- Build: staging
- # 5135
- Diff
- Hackwar:languagefilter
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is an initial code review of the languagefilter plugin. There are several sins in this plugin and I tried to simplify and improve the code where possible.
Testing instructions are simple:
- Set up a full fledged multi-lingual installation of Joomla with lots of different content and associations, etc.
- Check the current behavior.
- Apply the change
- See that the behavior did not change
jissues-bot
- | Labels |
Added:
?
|
||
Hannes, when you have time, give a look at #5129 (comment) and tell me if it is just a load of bullshit of mine or if there is any sense in it...
Yeah, I know... Travis is a pain in the back... 
@infograf768 Thanks for asking, appreciated!
I would say that I'm not "against" but I'm not totally "pro" either. After all this modification introduces some inconsistency whose nature and mechanism is not yet clear. I agree that a 301 is more correct, but as I said before I also have concerns about having 301 in such sheer amount. This should be test thoroughly "in the field".
I propose to implement the modification but at the same time have an option "Legacy redirect mode" to revert it in case anything "backfires". It should be plain easy: not even an "if" required, just use the option as the last parameter to $app->redirect()
Sorry, but no. We are not going to introduce another parameter for this. This already will make no really measurable difference for Google. If you are concerned about your search engine ranking, then you have lots of other areas where you can work on. I doubt that the redirect type for this redirect makes more than 0.001% difference for Google. It will make more of a difference for Google that Joomla overall will become faster by an improved languagefilter plugin and that itself is only measurable in 2 digit milliseconds.
OK, then let's cross fingers and hope it will not backfire in any way.
Of course the best solution would be not having redirects at all, but probably this is not achievable with the current architecture.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-20 07:55:57 |
Please see http://forum.joomla.org/viewtopic.php?f=711&t=882488&p=3292887#p3292887
It seems we may need a "true" added on line 371 (staging)
@Hackwar So far it seems to work nicely!
I noticed that redirect for logging-in users are now through POST and not GET...
With this too I have spurious 303 (I can show you, if you wish), and I tested that on two different PCs (Win 8.1 and Win 7)... Maybe 'cause my code base is 3.3.6 and not staging?