Feeling Lucky
?
[#5121] - [imp] Changing minimum upper limit search to 200 characters
- Closed
- 17 Nov 2014
- Medium
- Build: staging
- # 5121
- Diff
- infograf768:countsearch
- Success continuous-integration/travis-ci The Travis CI build passed Details
User tests: Successful: Unsuccessful:
See #5103
To test in en-GB, add var_dump ($upper_limit); after line 33 $upper_limit = $lang->getUpperLimitSearchWord(); in
ROOT/modules/mod_search/mod_search.php
You should get int 200
jissues-bot
- | Labels |
Added:
?
|
||
dgt41
- comment
- 16 Nov 2014
@infograf768 change this from 20 to 200 to make travis happy
infograf768
- comment
- 16 Nov 2014
@RCheesey
Please use staging instead of 3.3.6
Then patch with this PR.
Then make the modification manually as indicated above.
You will get:
brianteeman
- | Category | ⇒ | Search |
infograf768
- comment
- 17 Nov 2014
Simple patch. Merging. Thanks for testing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-17 07:59:29 |
Trying to test this but it's not clear what you mean by "you should get 200" - I added the line to the file as described but see no output in the front end Joomla 3.3.6 with sample data having module in a position or embedded in an article, or when adding the string to view.html.php on com_search either (assumed this would also be impacted by the change so tried to look there too.
Unable to see anything before or after applying patch therefore unable to test properly.
Further clarification would be helpful.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5121.