?

Success

User tests: Successful: Unsuccessful:

avatar dandpclements
dandpclements
15 Nov 2014

This is a proposed change for tracker issue #5083

The list of users online is currently based on sessions resulting in names being duplicated. This change removes the time field from the sql select statement field list and also group by list.

avatar dandpclements dandpclements - open - 15 Nov 2014
avatar jissues-bot jissues-bot - change - 15 Nov 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 15 Nov 2014

Adjusted the title of the PR.
PR looks fine to me.
When testing, just check if something breaks with that module. It should just remove the duplicated users.

avatar zero-24 zero-24 - change - 16 Nov 2014
Title
Update helper.php
Who's online module shows multiple entries for a user name in release 3
avatar zero-24 zero-24 - change - 16 Nov 2014
Category Front End Modules
avatar RCheesley RCheesley - test_item - 16 Nov 2014 - Tested successfully
avatar RCheesley
RCheesley - comment - 16 Nov 2014

Successful test, before applying users logged in on different browsers were duplicated, after applying they only show once.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5111.

avatar roland-d roland-d - test_item - 18 Nov 2014 - Tested successfully
avatar roland-d
roland-d - comment - 18 Nov 2014

@test: Success, after applying the patch, the duplicate usernames have disappeared.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5111.

avatar roland-d roland-d - change - 18 Nov 2014
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 18 Nov 2014

Moving to RTC as we have 2 successful tests

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5111.

avatar brianteeman brianteeman - change - 29 Nov 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 2 Dec 2014

Merged into staging. Thanks!

avatar zero-24 zero-24 - close - 2 Dec 2014
avatar Bakual Bakual - close - 2 Dec 2014
avatar Bakual Bakual - change - 2 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-02 21:11:07
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment