?
avatar alex-filat
alex-filat
10 Nov 2014

It seems wrong when search by all phrase like 'vase 24 sm' then com_search leave only 'vase' and do not inform about. I think when we serch with mode 'all phrase' than 'vase 24 sm' is legal resonable phrase from logic point of view and it has almost the same effect on performance like 'vase'.

avatar alex-filat alex-filat - open - 10 Nov 2014
avatar jissues-bot jissues-bot - change - 10 Nov 2014
Labels Added: ?
avatar vdespa vdespa - change - 13 Nov 2014
Category Search
avatar brianteeman brianteeman - change - 23 Nov 2014
Title
com_search cut all short worlds when search by all phrase
com_search cut all short words when search by all phrase
avatar alex-filat alex-filat - reference | - 16 Dec 14
avatar brianteeman brianteeman - change - 1 Jan 2015
Status New Information Required
avatar brianteeman
brianteeman - comment - 1 Jan 2015

Is this with regular search or smart search?
I couldnt replicate it with regular search


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5079.
avatar alex-filat
alex-filat - comment - 8 Jan 2015

It is with regular search. Can you please put actions you are doing for better understanding.

avatar alex-filat
alex-filat - comment - 15 Jan 2015

Probably you cannot reproduce because if you use search phrase 'vase 24' then component displays full phrase but searches only by 'vase' because it cuts all short words.

avatar brianteeman
brianteeman - comment - 15 Jan 2015

I suspect that this is your problem
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.localise.php#L62

You will see that there is a lower limit defined of 3 characters

On 15 January 2015 at 17:51, alex-filat notifications@github.com wrote:

Probably you cannot reproduce because if you use search phrase 'vase 24'
then component displays full phrase but searches only by 'vase' because it
cuts all short words.


Reply to this email directly or view it on GitHub
#5079 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar delfweb
delfweb - comment - 28 Jan 2015

No it is not my problem.
If you search by long phrase which is combination of long(ligal - satisfy all filter criterias) and short words then phrase must be used with short worlds. If i want serach by phrase 'vase 24' i am exactly want to see VASES 24 sm long and not VASES 34 sm or any other. If serch phrase consists from two short phrases f.e. 'sm 34' then it is not ligal because all phrases not passed filter conditions.

From perfomance point phrases 'vase' and 'vase 24' almost the same, that makes possible to implement this logic.

avatar brianteeman
brianteeman - comment - 14 Mar 2015

Sorry but I disagree - it is exactly your problem - any search term that is smaller than the value set will be ignored. To change it for your site you need to change the minimum search length


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5079.
avatar brianteeman brianteeman - close - 14 Mar 2015
avatar brianteeman brianteeman - change - 14 Mar 2015
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2015-03-14 10:21:50
Closed_By brianteeman
avatar brianteeman brianteeman - change - 14 Mar 2015
Closed_Date 2015-03-14 10:21:50 2015-03-14 10:21:51
avatar brianteeman brianteeman - close - 14 Mar 2015
avatar alex-filat
alex-filat - comment - 14 Mar 2015

No it is still not. If i limit search world by 2 characters then server could be crushed in easy way.
Probably it is difficult for understanding but it makes real problems for our client and as a result for us.
I understant that all participant very busy and would not be involved into descovering diffucult thing like this, but it does not make Joomla better. This task was considerted 5 monthes and now it is rejected.
All of this just frustrating. Nice direction, keep this way.

avatar mbabker
mbabker - comment - 14 Mar 2015

Just as described, the issue relates to the method that was linked to above. When searching with the "older" search component, there is a method that checks the length of each term in the search and filters anything that doesn't match the minimum length. By default, this means a search will exclude any term with only 1 or 2 characters. "vase 24" is considered two terms as the terms are split by spaces, and "24" does not match the three character minimum so is stripped. As coded, the existing behavior is correct. What it sounds like you're looking for is an extended logic which would allow "vase 24" as a single term, that would require quite a bit of work on the search platforms and our language parsing capabilities and is borderline not feasible at this time (in my opinion).

avatar alex-filat
alex-filat - comment - 15 Mar 2015

Hi Michael, i have already made pull request with all nessesary improvements we are using inside our company. It is very small change in code , i just cannot understand how to connect this discussion to pull request, i would be very appreciate if you help #5442.

avatar infograf768
infograf768 - comment - 15 Mar 2015

Would be interesting to provide a way to override the xx-XX.localise.php in a similar way we provide language constants/values override in language manager.

Add a Comment

Login with GitHub to post a comment