Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5064] - Remove the 2.5 EOS plugin if present

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
8 Nov 2014

This PR is in conjunction with #5063 and will remove the 2.5 End of Support plugin for users who have it installed and upgrade a 2.5 site to 3.x.

avatar mbabker mbabker - open - 8 Nov 2014
avatar jissues-bot jissues-bot - change - 8 Nov 2014
Labels Added: ?
avatar zero-24 zero-24 - change - 9 Nov 2014
Category ⇒ Plugins Updating
avatar zero-24
zero-24 - comment - 7 Dec 2014

@test

What i did

I will retest if we can fix com_installer (IIRC this is easy but i don't get in mind how this can be fixed ...)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5064.

avatar infograf768
infograf768 - comment - 8 Dec 2014

Do we run the script.php when installing though Extension Manager=>Install?

avatar wilsonge
wilsonge - comment - 14 Dec 2014

Yes.

avatar zero-24
zero-24 - comment - 22 Dec 2014

@test unsuccessful

Warning
Plugin Uninstall: Trying to uninstall a core plugin: PLG_EOSNOTIFY

http://issues.joomla.org/tracker/joomla-cms/5064#event-52778

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5064.
avatar zero-24 zero-24 - test_item - 22 Dec 2014 - Tested unsuccessfully
avatar mbabker
mbabker - comment - 22 Dec 2014

D'oh! It's protected. I'll hack up a fix in a little bit.

avatar zero-24
zero-24 - comment - 27 Dec 2014

@mbabker here is a PR i hope it helps: mbabker#19

avatar zero-24
zero-24 - comment - 27 Dec 2014

@mbabker something like this:

        $id = $db->setQuery(
            $db->getQuery(true)
                ->update('#__extensions')
                ->set('protected' = '0')
                ->where('name' = 'plg_quickicon_eosnotify');
        )->execute();
avatar mbabker
mbabker - comment - 27 Dec 2014

That's the gist of it. Now we just need to use proper quoting syntax for all of our databases:

$db->setQuery(
    $db->getQuery(true)
        ->update('#__extensions')
        ->set('protected = 0')
        ->where($db->quoteName('name') . ' = ' . $db->quote('plg_quickicon_eosnotify');
)->execute();
avatar mbabker
mbabker - comment - 27 Dec 2014

@zero-24 I've added the query at mbabker@49e51e8 so we should be good to go now. Thanks!

avatar zero-24
zero-24 - comment - 27 Dec 2014

:+1: I will have a test later today.

avatar zero-24 zero-24 - test_item - 27 Dec 2014 - Not tested
avatar zero-24
zero-24 - comment - 28 Dec 2014

@mbabker still don't work this should fix it: mbabker#20

avatar zero-24
zero-24 - comment - 28 Dec 2014

@test successful. One more tester

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5064.
avatar zero-24 zero-24 - test_item - 28 Dec 2014 - Tested successfully
avatar Hackwar
Hackwar - comment - 12 Feb 2015

@test successfull.

avatar zero-24 zero-24 - change - 12 Feb 2015
Status Pending ⇒ Ready to Commit
avatar Hackwar Hackwar - test_item - 12 Feb 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 12 Feb 2015

Thanks @Hackwar and @mbabker moving this to RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5064.
avatar brianteeman brianteeman - change - 12 Feb 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 12 Feb 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-02-12 12:41:15
avatar wilsonge wilsonge - close - 12 Feb 2015
avatar wilsonge wilsonge - reference | - 12 Feb 15
avatar wilsonge wilsonge - merge - 12 Feb 2015
avatar wilsonge wilsonge - close - 12 Feb 2015
avatar wilsonge
wilsonge - comment - 12 Feb 2015

Merged - thanks!

Add a Comment

Login with GitHub to post a comment