User tests: Successful: Unsuccessful:
I've created new pull request.
Hi Julio,
Looks like it's out of sync with master. Please check it.
This is a very bad solution to this problem. It will generate a lot more unnecessary load on websites and should not be merged.
@juliopontes thanks for the contribution! As the code submitted is a year old, and out of sync, I'm going to close the PR for now. Feel free to reopen the issue if you have time to re-sync it.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2013-12-06 03:22:51 |
Hi I came across a bug in components/com_content/router.php in Joomla 3.3.1
If i enable seo friendly urls and mod_rewrite and call a menu item in the following way:
http://localhost/website_name/menu_name/2-uncategorised
then the following function will determine that the path is a category path which is totally wrong in my opinion.
Code:
public function build(&$query) {
...
if ($view == 'category' || $view == 'article') {
if (!$menuItemGiven) {
$segments[] = $view;
}
unset($query['view']);
if ($view == 'article') {
...
} else {
// call lands here
}
...
}
This might lead to duplicate content. Is there some sort of fix to this behaviour.
All the best
David
Please don't post in an old and closed pull request a new bug report. Yes, this is a known bug and I'm working on fixing it. Its been around since Joomla 1.7.
Thanks for coding this, Julio!
For anyone interested, here's the tracker item on JoomlaCode:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29428