[#5036] - [fix] Correcting span6 columns in batch modal
- Closed
- 8 Nov 2014
- Medium
- Build: staging
- # 5036
- Diff
- infograf768:batchmodalcolumns
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
batch modals do not display the span6 columns i.e. display the parameters as a single column.
before patch:
after patch
this has to be corrected before testing the bunch of PRs to display the parameters consistently
jissues-bot
- | Labels |
Added:
?
|
||
It does work here in rtl. You may need to purge cache (Using Persian here)
I just also corrected another issue in rtl
We had
.row-fluid [class*="span"] {
margin-left: 15px;
}
``
instead of margin-right`
The modal box has the exact appearance as your screenshot. What I meant was, when I am resizing the browser window and the two-columns changes to one column then the labels and fields are not totally right justified as you can see in my screenshot. The are though in ltr. Just a very minor thing.
Corrected the rtl alignment too. Please test
I did not see the behavior when I created my patch. Just re-tested with in other resolution and I was able to reproduce the misalignment of the options when my browser is in 800x600px.
Please test this PR
Perfect! Thank you!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-08 15:20:38 |
Thanks for testing
@test works ltr but not rtl (tested with arabic)
