User tests: Successful: Unsuccessful:
Bug report for overall inconsistancy of order of options in Batch screens:
http://issues.joomla.org/tracker/joomla-cms/5028
Labels |
Added:
?
|
After this patch, items are not aligned, was that the intention?
To get this, pr should be:
diff --git a/administrator/components/com_content/views/articles/tmpl/default_batch.php b/administrator/components/com_content/views/articles/tmpl/default_batch.php
index 20b923f..7f899f8 100644
--- a/administrator/components/com_content/views/articles/tmpl/default_batch.php
+++ b/administrator/components/com_content/views/articles/tmpl/default_batch.php
@@ -22,9 +22,4 @@
<div class="control-group span6">
<div class="controls">
- <?php echo JHtml::_('batch.tag'); ?>
- </div>
- </div>
- <div class="control-group span6">
- <div class="controls">
<?php echo JHtml::_('batch.language'); ?>
</div>
@@ -37,4 +32,6 @@
</div>
</div>
+ </div>
+ <div class="row-fluid">
<?php if ($published >= 0) : ?>
<div class="control-group span6">
@@ -45,4 +42,11 @@
<?php endif; ?>
</div>
+ <div class="row-fluid">
+ <div class="control-group span6">
+ <div class="controls">
+ <?php echo JHtml::_('batch.tag'); ?>
+ </div>
+ </div>
+ </div>
</div>
<div class="modal-footer">
Also, not sure Tags should be below category as that one is the essential decision on how the batch will globally act.
I have not tested the other related PRs, but if they behave the same, my comments apply there too.
hmm, just found out the non-aligned issue is from a former change...
and we lose the 2 columns.. weird
@test Works!
Remark to @infograf768: in the user manager you will find only two options in the batch dialog, but also in one column.
Status | Pending | ⇒ | Ready to Commit |
Moving to RTC as we have 2 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5029.
Thank you all for testing & making improvements!
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-09 07:31:16 |
@test: succesful. The colors look good to me ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5029.