? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
8 Nov 2014

Bug report for overall inconsistancy of order of options in Batch screens:
http://issues.joomla.org/tracker/joomla-cms/5028

avatar pe7er pe7er - open - 8 Nov 2014
avatar jissues-bot jissues-bot - change - 8 Nov 2014
Labels Added: ?
avatar yireo
yireo - comment - 8 Nov 2014

@test: succesful. The colors look good to me ;)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5029.

avatar infograf768
infograf768 - comment - 8 Nov 2014

After this patch, items are not aligned, was that the intention?
wrong batch

Should not it be?
aligned

To get this, pr should be:

diff --git a/administrator/components/com_content/views/articles/tmpl/default_batch.php b/administrator/components/com_content/views/articles/tmpl/default_batch.php
index 20b923f..7f899f8 100644
--- a/administrator/components/com_content/views/articles/tmpl/default_batch.php
+++ b/administrator/components/com_content/views/articles/tmpl/default_batch.php
@@ -22,9 +22,4 @@
            <div class="control-group span6">
                <div class="controls">
-                   <?php echo JHtml::_('batch.tag'); ?>
-               </div>
-           </div>
-           <div class="control-group span6">
-               <div class="controls">
                    <?php echo JHtml::_('batch.language'); ?>
                </div>
@@ -37,4 +32,6 @@
                </div>
            </div>
+       </div>
+       <div class="row-fluid">
            <?php if ($published >= 0) : ?>
                <div class="control-group span6">
@@ -45,4 +42,11 @@
            <?php endif; ?>
        </div>
+       <div class="row-fluid">
+           <div class="control-group span6">
+               <div class="controls">
+                   <?php echo JHtml::_('batch.tag'); ?>
+               </div>
+           </div>
+       </div>
    </div>
    <div class="modal-footer">

Also, not sure Tags should be below category as that one is the essential decision on how the batch will globally act.

avatar infograf768
infograf768 - comment - 8 Nov 2014

I have not tested the other related PRs, but if they behave the same, my comments apply there too.

avatar infograf768
infograf768 - comment - 8 Nov 2014

hmm, just found out the non-aligned issue is from a former change...

avatar infograf768
infograf768 - comment - 8 Nov 2014

and we lose the 2 columns.. weird

avatar infograf768
infograf768 - comment - 8 Nov 2014

If the css is deleted, we will get with your PR:
screen shot 2014-11-08 at 11 21 56

And that is fine for me. :+1:

avatar infograf768
infograf768 - comment - 8 Nov 2014

See
#5036

avatar dbhurley
dbhurley - comment - 8 Nov 2014

:+1:

avatar waader
waader - comment - 8 Nov 2014

@test Works!
Remark to @infograf768: in the user manager you will find only two options in the batch dialog, but also in one column.

avatar roland-d roland-d - alter_testresult - 8 Nov 2014 - waader: Tested successfully
avatar roland-d roland-d - alter_testresult - 8 Nov 2014 - yireo: Tested successfully
avatar roland-d roland-d - change - 8 Nov 2014
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 8 Nov 2014

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5029.

avatar pe7er
pe7er - comment - 8 Nov 2014

Thank you all for testing & making improvements!

avatar infograf768 infograf768 - close - 9 Nov 2014
avatar infograf768 infograf768 - change - 9 Nov 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-11-09 07:31:16

Add a Comment

Login with GitHub to post a comment