See #4703

@donald-pg can you add testinstructions? I'm not sure how i can test this. Thanks

Testinstructions:
Install Joomla on two webservers, one requiring FTP to be used, the other not requiring FTP to be used.
Upon completion in both situations:

• the installation folder must be removed without problem.
• Verify content of robots.txt, unchanged if existing before installation, otherwise equal to content of robots.txt.dist.
  • no joomla.xml may exist in root folder.

Since configuring FTP during the installation process has been removed so there is no way to get to the remove installation folder part with FTP information loaded. I'm assuming we need to modify the text string to let people know they can't remove the installation folder in certain conditions (where you need FTP) as removing the installation folder button when needing FTP has not worked since the FTP part has been removed during the initial setup.

That being said...try the Remove Installation Folder button. It should be exactly the same as before as I just removed code that is no longer being executed or used.

@donald-pg

Since configuring FTP during the installation process has been removed so there is no way to get to the remove installation folder part with FTP information loaded.

It is only hidden if joomla detect a server that FTP require it will disply it. See: #1980

Thanks. I'll revise the patch then. I was never able to see the FTP options and several others at the bug squashing session couldn't see the FTP screen so we all assumed it had been removed. I'll have to redo my patch to load the options as right now, the version that is out now, it will never drop into the FTP code because the options variable is never setup in that function.

It may take me a little bit to reconfigure my local environment to get the FTP options to show so I can reproduce the original problem of #4703 then fix it.

Thanks again for the info.

I have to say that I don't understand why all that code is necessary to delete that stuff... JFolder/JFile should be aware of FTP if it is set. So instead of having dozens of checks, calling JFolder/JFile directly should be enough, as @donald-pg has done. The only thing that we might have to do first, is to set the global config data regarding the FTP in case JFolder/JFile does not have access to that in the installation application automatically. In that case however, we should rather fix that than forcing so much code in there...

Any update @donald-pg ?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5025.

After considerable time without update I am closing this. If you feel this is still an issue please provide further information and it can always be reopened

Hi @brianteeman, the issue is still valid and should be tested. As far as I can see, this code is still up-to-date and should be merged if possible. Simply needs testers...

Donald said he would revise the patch and hasn't

I can offer to work on this some time in this month and provide a new PR, but that would require that I remember this PR and that it be left open. Would that be acceptable?

Let's not do silly things like that. We can't and shouldnt keep stale
issues open for ever. If you want to create a new PR then make a note in
your calendar.

ok