Joomla! Issue Tracker | Joomla! CMS #5019 - Fixed wrong redirection by menu item

Closed
1 Oct 2015
Medium
Build: staging
# 5019
Diff
clinchergt:4934

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

clinchergt
8 Nov 2014

An attempt to fix issue #4934

Steps to reproduce the issue

create an article for registered users only,
create a menu item to aforementioned article,
go to the front-end of the site and log in,
access the article through the menu item,
log out,
click menu item.

Expected result

Get error explaining I'm not authorized to access the article since I'm not logged in.

Additional Information

Problem seemed to only be happening with Firefox.

Make sure to use an incognito/private browsing window to ensure that neither cookies nor the cache will affect the testing.

If you try accessing the article without ever having logged in, you'll get what was described in the "Expected result" section, so it's the logging in that's causing this behaviour after logging out.

This PR deals with the problem making the logout not spit out a "permanently moved" code.

Votes

# of Users Experiencing Issue

1/1

Average Importance Score

3.00

a8fd63a 8 Nov 2014

Fixed wrong redirection by menu item

clinchergt - open - 8 Nov 2014

jissues-bot - change - 8 Nov 2014

Labels

Added: ?

jissues-bot - change - 8 Nov 2014

Labels

Added: ?

RCheesley - test_item - 8 Nov 2014 - Tested successfully

RCheesley - comment - 8 Nov 2014

Successful test - had to open the site in an incognito window due to cached redirects as recommended.

On application of patch the correct error message is displayed.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5019.

philipwatz - test_item - 8 Nov 2014 - Tested successfully

philipwatz - comment - 8 Nov 2014

jes it work

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5019.

crystalenka - comment - 8 Nov 2014

SEF is causing strange issues in 3.3.6 - despite being in incognito on Firefox. I'd revisit this, make sure SEF is turned on because I can't reproduce the issue with SEF turned on.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5019.

yireo - comment - 8 Nov 2014

I've been testing this for half an hour: When repeating the test, I got the same results: When in normal browser mode, the message pops up. When in Incognito Mode, after logging in and logging out again, the warning does not appear. However, looking closer shows me that I'm actually being redirected from the new Menu-Item back to the homepage. When debugging things using die() statements in the Joomla code, I can see that the Joomla index.php is never executed but Firefox itself is redirecting back to the Joomla homepage, based on the previous results. This seems like a caching issue with Firefox to me, not an issue with Joomla.

@test: Unable to confirm Joomla issue

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5019.

roland-d - alter_testresult - 8 Nov 2014 - yireo: Tested unsuccessfully

roland-d - comment - 27 Nov 2014

@clinchergt Can you verify the outcome by @yireo ?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5019.

6bf2a1d 8 May 2015

Merge branch 'staging' into 4934

6a3e8a1 8 May 2015

Fixes wrong menu redirection by removing HTTP 301 code

clinchergt - comment - 8 May 2015

@yireo and @roland-d: sorry for taking so long. I read your comments and decided to check further. I've updated the PR with a, imo, better fix.

Apparently, that true I removed was returning a 301 code (page permanently moved). I'm guessing Firefox and IE handle this differently from Chrome, so that's why it wasn't happening on both. However, even if they do handle it differently, this redirect does not warrant a 301 code since the page hasn't been moved.

I'd appreciate a PR review and some testers :D

jissereitsma - comment - 9 May 2015

(I'm the same guy as @Yireo) I checked the PR and it looks dead-simple to me. Next, I tested it myself to see the difference. Without the patch a 303 code is sent, with the patch a 301 code is sent. Looks fine to me!