? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
5 Nov 2014

Note this also update the symfony yaml component as this is just a composer update

Symfony YAML goes to 2.6.0. Main addition is this feature http://symfony.com/blog/new-in-symfony-2-6-support-for-object-maps-in-yaml-component

There is also a Joomla Filter package update (which when merged will fix the bug reported in #5013) which is also fully b/c

Testing

You will need to test this on 3.4 alpha or directly on staging. If you test this on patchtester with Joomla 3.4 alpha you will need to manually add the composer.json file from the staging repo (https://github.com/joomla/joomla-cms/blob/staging/composer.json) or else you will get the error Error
The file marked for modification does not exist: composer.json
as the composer.json file is not included in the distributed releases

avatar wilsonge wilsonge - open - 5 Nov 2014
avatar jissues-bot jissues-bot - change - 5 Nov 2014
Labels Added: ?
avatar wilsonge wilsonge - change - 5 Nov 2014
The description was changed
avatar Bakual
Bakual - comment - 5 Nov 2014

PHPMailer goes from 2.5.8 -> 2.5.9
Major changes according to their release post on GitHub (https://github.com/PHPMailer/PHPMailer/releases/tag/v5.2.9)

Major changes:
• The autoloader is no longer autoloaded automatically, and the PHPMailer class does not require the SMTP class explicitly, so you must either load the autoloader yourself (as all the docs and examples have done for the last year), or load the SMTP class yourself. This fixes the inability to substitute your own SMTP subclass, and also improves interoperability with other autoloaders.
• Support for data-uri images
• Debug output handling improved in SMTP
• You can now supply your own callable for debug output
• Avoid PCRE infinite recursion in some PCRE versions
• Consistency improvements
• Cleaned up example code See the changelog for more details.

PHPMailer/PHPMailer@v5.2.8...v5.2.9


Yaml goes from 2.5.5 -> 2.5.6. The changes for Yaml seem to be quite minimal :smile:
symfony/Yaml@v2.5.5...v2.5.6

avatar brianteeman brianteeman - change - 13 Nov 2014
Category External Library
avatar brianteeman
brianteeman - comment - 23 Nov 2014

Do these "major changes" create b/c issues for us?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4997.

avatar wilsonge
wilsonge - comment - 23 Nov 2014

We're loading via composer anyhow so the autoloading doesn't affect us. Everything else seems like bug fixes and features so I'm pretty sure no.

avatar waader
waader - comment - 3 Dec 2014

@test works

I could only test the mass mail function and that worked. Using the "Privat Messages Manager" and there selecting the recipients gives me a blank list although I have created a lot of users. I get the same result with a postgresql installation but in addition "::character varying" is display in the recipients field.

avatar wilsonge
wilsonge - comment - 3 Dec 2014

Users won't show there - only people with backend access and who can access the component

avatar waader
waader - comment - 3 Dec 2014

Thanks for the explanation. I didn´t use that component before. So, it works even with postgresql ;-).

avatar wilsonge wilsonge - change - 10 Dec 2014
The description was changed
avatar roland-d
roland-d - comment - 16 Dec 2014

@test:
Created a user from BE and received mail as new account has been created: OK
Created a user from FE and received mail as new account has been created: OK
Try to send an email link to friend: Not OK --> Email could not be sent (works OK before patch)
Private message to other super user: OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4997.
avatar roland-d roland-d - test_item - 16 Dec 2014 - Tested unsuccessfully
avatar waader
waader - comment - 16 Dec 2014

@roland-d "Try to send an email link to friend" Where can I do that?

avatar roland-d
roland-d - comment - 16 Dec 2014

@waader It is the email option at any article (provided you have it enabled, which it is by default). See the screenshot for more details:
article_mail_link

avatar roland-d roland-d - test_item - 16 Dec 2014 - Tested successfully
avatar roland-d
roland-d - comment - 16 Dec 2014

@wilsonge @waader The issue I found has nothing to do with this PR. The PR is sound and tested OK now.
The issue I see is related to this line:
https://github.com/joomla/joomla-cms/blob/staging/components/com_mailto/controller.php#L50
This gets triggered all the time, only if I hit the Send button quite regularly mails will go out but I can also get this warning quite regularly. It seems the spam protection is not so stable.

avatar waader
waader - comment - 16 Dec 2014

@roland-d Thanks for pointing me there. I can reproduce the issue.

avatar waader waader - test_item - 16 Dec 2014 - Tested successfully
avatar wilsonge
wilsonge - comment - 17 Dec 2014

Awesomes :) Can we merge this PR then and create an issue for com_mailto?

avatar wilsonge wilsonge - change - 17 Dec 2014
Status Pending Ready to Commit
avatar wilsonge
wilsonge - comment - 17 Dec 2014

RTC anyhow with 2 good tests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4997.
avatar roland-d roland-d - close - 17 Dec 2014
avatar roland-d roland-d - change - 17 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-17 16:26:10

Add a Comment

Login with GitHub to post a comment