User tests: Successful: Unsuccessful:
Note this also update the symfony yaml component as this is just a composer update
Symfony YAML goes to 2.6.0. Main addition is this feature http://symfony.com/blog/new-in-symfony-2-6-support-for-object-maps-in-yaml-component
There is also a Joomla Filter package update (which when merged will fix the bug reported in #5013) which is also fully b/c
You will need to test this on 3.4 alpha or directly on staging. If you test this on patchtester with Joomla 3.4 alpha you will need to manually add the composer.json
file from the staging repo (https://github.com/joomla/joomla-cms/blob/staging/composer.json) or else you will get the error Error
as the composer.json file is not included in the distributed releases
The file marked for modification does not exist: composer.json
Labels |
Added:
?
|
Category | ⇒ | External Library |
Do these "major changes" create b/c issues for us?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4997.
We're loading via composer anyhow so the autoloading doesn't affect us. Everything else seems like bug fixes and features so I'm pretty sure no.
@test works
I could only test the mass mail function and that worked. Using the "Privat Messages Manager" and there selecting the recipients gives me a blank list although I have created a lot of users. I get the same result with a postgresql installation but in addition "::character varying" is display in the recipients field.
Users won't show there - only people with backend access and who can access the component
Thanks for the explanation. I didn´t use that component before. So, it works even with postgresql ;-).
@test:
Created a user from BE and received mail as new account has been created: OK
Created a user from FE and received mail as new account has been created: OK
Try to send an email link to friend: Not OK --> Email could not be sent (works OK before patch)
Private message to other super user: OK
@wilsonge @waader The issue I found has nothing to do with this PR. The PR is sound and tested OK now.
The issue I see is related to this line:
https://github.com/joomla/joomla-cms/blob/staging/components/com_mailto/controller.php#L50
This gets triggered all the time, only if I hit the Send button quite regularly mails will go out but I can also get this warning quite regularly. It seems the spam protection is not so stable.
Awesomes :) Can we merge this PR then and create an issue for com_mailto?
Status | Pending | ⇒ | Ready to Commit |
RTC anyhow with 2 good tests
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-17 16:26:10 |
PHPMailer goes from 2.5.8 -> 2.5.9
Major changes according to their release post on GitHub (https://github.com/PHPMailer/PHPMailer/releases/tag/v5.2.9)
PHPMailer/PHPMailer@v5.2.8...v5.2.9
Yaml goes from 2.5.5 -> 2.5.6. The changes for Yaml seem to be quite minimal
symfony/Yaml@v2.5.5...v2.5.6