? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
5 Nov 2014

Test:
Install a basic multilingual site from scratch.
See: #4988
Create a submenu in the mainmenu of one of the languages.

Using PhpMyadmin, delete in the _menu table the row mainmenu with Home set to Language All, i.e. *

Display the site and the submenu
The breadcrumbs will not show the right items
you will also get an error:
PHP Notice: Trying to get property of non-object in ROOT/modules/mod_breadcrumbs/helper.php on line 51

Patch and test again.

(Don't forget to kill that test site as it is not normal to delete the mainmenu home menu item set to All languages in a multilingual site

avatar infograf768 infograf768 - open - 5 Nov 2014
avatar jissues-bot jissues-bot - change - 5 Nov 2014
Labels Added: ?
avatar fontanil
fontanil - comment - 5 Nov 2014

@test
PR works as intended
Thanks

avatar waader
waader - comment - 5 Nov 2014

The test works as described. However, when I click on "Joomla" in the "Popular Tags" module - I have installed "Default English (GB) Sample Data" - I get several notices, like this one:
Notice: Trying to get property of non-object in C:\xampp\htdocs\joomla33_test\modules\mod_menu\helper.php on line 40

avatar zero-24 zero-24 - alter_testresult - 5 Nov 2014 - fontanil: Tested successfully
avatar zero-24 zero-24 - alter_testresult - 5 Nov 2014 - waader: Tested successfully
avatar zero-24
zero-24 - comment - 5 Nov 2014

moving to RTC based on tests by @fontanil and @waader

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4994.

avatar zero-24 zero-24 - change - 5 Nov 2014
Category Multilanguage
avatar zero-24 zero-24 - change - 5 Nov 2014
Status Pending Ready to Commit
avatar Bakual
Bakual - comment - 5 Nov 2014

However, when I click on "Joomla" in the "Popular Tags" module - I have installed "Default English (GB) Sample Data" - I get several notices, like this one:
Notice: Trying to get property of non-object in C:\xampp\htdocs\joomla33_test\modules\mod_menu\helper.php on line 40

@waader Do you get that error also without the patch applied? Or only when it is applied? Sounds like a different issue to me.

avatar waader
waader - comment - 5 Nov 2014

That was meant as a remark. To be more precise: I get these notices with or without applying the patch under the above testing assumption - deleting that row in the _menu table.

avatar Bakual Bakual - change - 5 Nov 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 5 Nov 2014

Merged into staging, thanks!

avatar infograf768 infograf768 - close - 5 Nov 2014
avatar infograf768 infograf768 - change - 5 Nov 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-11-05 20:25:49
avatar infograf768
infograf768 - comment - 6 Nov 2014

Folks, please test
#5002

it solves the issue described by @waader above

Add a Comment

Login with GitHub to post a comment