[#4992] - Standardize method for getting database object in models
- Closed
- 7 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 4992
- Diff
- wilsonge:getdatabase
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
We have a getDbo() method in JModelLegacy (https://github.com/joomla/joomla-cms/blob/staging/libraries/legacy/model/legacy.php#L373) . This effectively is still a proxy to JFactory::getDatabase() - however it can be injected into the class and I see us standardising on using this method as us really promoting the use of injection into MVC classes instead of using these static JFactory methods.
Testing
To test navigate around the backend and check all the views work affected parts are:
- Saving a category
- Saving a banner
- Displaying the system information
- Saving a contact
- Saving an article
- Viewing the list of installed extensions in Extension Manager
- Checking for existing extensions when using Discover in Extension Manager
- Checking the database is upto date in Extension Manager
- Using the purge cache button in the Joomla Update Component
- Saving a menu item
- Getting the list of available menu types when creating a menu item
- Saving a newsfeed
- Loading module lang files
- Saving a template
- Getting the user groups for a user in User Manager
As this is about getting the database object it should be REALLY obvious if something is broken (like the page completely dies).
On top of that check using the vote plugin in the frontend of Joomla in an article and registration view in the frontend
jissues-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Components |
| Easy | No | ⇒ | Yes |
Yeah this is one of those things where because patchtester replaces the file you get misleading results. That bug was completely unrelated to this patch and fixed with 842d95b but because patch-tester replaces the whole file whenever anything gets changed rather than applying the actual diff it looks like the bug is the cause of the patch. I've just merged in staging and that should fix things up :)
Seems to work.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4992.
@test with success, i succeed to :
- view an article in frontend
- make a frontend registration, login and log out in frontend
- display a contact detail in frontend
- edit and save an article in frontend
- edit and save an article in backend
Perhaps, it may needs more tests intructions on other joomla functions !?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4992.
I've tried to write the complete list of things affected. Thanks so much for testing!
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
There's a green merge button. GitHub seems to think everything is up to date?
I just merged in staging and there weren't any conflicts - maybe try applying the diff from https://github.com/joomla/joomla-cms/pull/4992.diff ?
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-07 21:56:21 |
| Closed_By | ⇒ | wilsonge |
Tested this patch on 3.3.6 and I am unable to save any articles with changes - I get the following error:
Notice: Undefined variable: app in /administrator/components/com_content/models/article.php on line 497
I can change the article state from article manager, but any time I try to change anything within the article itself, I get the error above.
This error does not occur without the patch applied.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4992.