[#4971] - com_tags : router error
- Closed
- 8 Dec 2014
- Medium
- Build: staging
- # 4971
- Diff
- b92:patch-11
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Steps to reproduce the issue
Install Joomla (Test English (GB) Sample Data), for example
From the backend set the configuration ‘Search Engine Friendly URLs’ = ‘YES’
Use the url: index.php?option=com_tags&view=tag&layout=list&id[0]=3 (not sef url into a sef one. The id can have another value and NO Itemid has to be set)
You will have 3 times the error:
Notice: Array to string conversion in /libraries/cms/router/site.php on line 465
The proposal to fix is to replace
$id = $query['id'];
with
$id = (int) $query['id'];
which seems coherent with the test line 80
Expected result
No error
Actual result
Notice: Array to string conversion in /libraries/cms/router/site.php on line 465
System information (as much as possible)
Joomla 3.3.6
- the case 'alone' &id[0]=2
So I do not know ... may more complex for the fix. But the issue still there!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4971.
brianteeman
- | Category | ⇒ | SEF Tags |
1/ The code updated impact only view=tags (without s :) )
=> Is someone knows how to check all the cases for this view, please let me know (it's seems ok to me)
2/ Rechecking this router.php I saw that there is cases check for $advanced but
$params= JComponentHelper::getParams('com_tags');
$advanced = $params->get('sef_advanced_link', 0);
the variable is never set (out of like that) somewhere into the whole Joomla install !
Is it a forgotten code (this is the same comment for some other components: com_contact, com_content, com_newsfeeds, sef_advanced_link)?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4971.
sef_advanced is sort of a hidden feature. It was once meant to made available but never worked reliable enough. For now you can ignore that part. We're fine if it works without that 
| Status | New | ⇒ | Closed |
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/4971
Closing as we have a PR by @Hackwar here: #5347
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4971.
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-08 10:47:19 |
com_tags is a bit a special case in that the
idcan be an integer (&id=1), a coma separated list of ids (&id=1,2,3) or an array of ids (&id[0]=1&id[1]=2&id[2]=3).You need to make sure all three cases work.