[#4941] - Make icon spacing consistent based on .css
- Closed
- 23 Dec 2014
- Medium
- Build: staging
- # 4941
- Diff
- N6REJ:Icons-pr
User tests: Successful: Unsuccessful:
@phproberto @betweenbrain Hopefully this is right his time!
jissues-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-27 19:32:37 |
| Status | Closed | ⇒ | New |
brianteeman
- | Category | ⇒ | Templates (admin) Templates (site) UI/UX |
| Status | New | ⇒ | Pending |
How can this be tested, please describe how I can help.
@jamgit sorry I forgot to do that when I had to change pr's... so, to test, look @ the icons, such as edit, in any/all views and pre-patch you will see spaces, sometimes before , sometimes after also. This can best be viewed in the inspector as shown in these 2 images. After patch the visual space should still remain but no hardcoded spaces should exist anymore. Everything should be lined up properly vertically as well.
lucky you, the PR still applies
yay! lol
Bear
On 11/6/2014 01:44, infograf768 wrote:
lucky you, the PR still applies
—
Reply to this email directly or view it on GitHub
#4941 (comment).No virus found in this message.
Checked by AVG - www.avg.com http://www.avg.com
Version: 2015.0.5315 / Virus Database: 4189/8521 - Release Date: 11/06/14
| Status | Pending | ⇒ | Closed |
| Closed_Date | 2014-10-27 19:32:37 | ⇒ | 2014-12-23 18:27:16 |
Passed TRAVIS and ready for testing.