How can a change in the codemirror css effect an issue reported in TinyMCE

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4930.

I guess it was too late to touch anything. Anyway the CodeMirror had similar issue on chrome, now both fixed.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4930.

I can confirm that your change does fix the issue for tinymce and google chrome. However this is an external library so I dont know what the situation is with editing it. @gewilson do you know? Is there an official update?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4930.

@okonomiyaki3000 is the one who did the last few PRs to update that editor. He may know if this can be fixed upstream.

They were the code mirror changes. George did the tinymce changes IIRC
On 25 Oct 2014 13:59, "Thomas Hunziker" notifications@github.com wrote:

@okonomiyaki3000 https://github.com/okonomiyaki3000 is the one who did
the last few PRs to update that editor. He may know if this can be fixed
upstream.

—
Reply to this email directly or view it on GitHub
#4930 (comment).

I think the CodeMirror chsnges should be removed from this PR as it is extremely unlikely they have anything at all to do with TinyMCE issues.

If you have an improvement to make to CodeMirror, I suggest you submit a PR to that project. If it gets into a future release, it will end upon Joomla soon.

I assume the same goes for TinyMCE but I don't know much about it. I just disable it on all my sites anyway.

They were the code mirror changes. George did the tinymce changes IIRC

Now that you say it. I only happend to look at code and saw the changes in the codemirror css. Sorry for that confusion then.

Anyway I think both projects should be fixed upstream indeed or we end up with the same issue in the next round of updates.

Looks like we are at least one version behind on TinyMCE
On 25 Oct 2014 14:51, "Thomas Hunziker" notifications@github.com wrote:

They were the code mirror changes. George did the tinymce changes IIRC

Now that you say it. I only happend to look at code and saw the changes in
the codemirror css. Sorry for that confusion then.

Anyway I think both projects should be fixed upstream indeed or we end up
with the same issue in the next round of updates.

—
Reply to this email directly or view it on GitHub
#4930 (comment).

Removed the CodeMirror changes, the TinyMCE is 4.1.2, currently they released 4.1.6. Question is, will it affect other templates/scripts we have there?

Never correct an external library!
I am now looking at version 4.16

Version 416 solves the issue. Will create a new PR. Closing this.

Please test
#4935