[#4910] - Deprecate JObject
- Closed
- 24 Oct 2014
- Medium
- Build: staging
- # 4910
- Diff
- wilsonge:patch-24
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
JObject is one of the last classes remaining from the PHP 4 era. It has two uses. JError setting (now deprecated) and setting and getting class vars. In the past this allowed us to create our own public and private variables. However now this is happily not the case as PHP5 meant we could set these in the class. For that reason I'd like to mark this class as deprecated.
Just like JError we can't feasibly remove all uses before Joomla 4 in a b/c way. But it points to developers to stop using this class where feasibly possible
Note this PR going through doesn't mean you shouldn't test #4909 (it's really good to have full unit test coverage as this class is still going to be used in many places in the 3.x series)
jissues-bot
- | Labels |
Added:
?
|
||
847FILE: /home/travis/build/joomla/joomla-cms/libraries/joomla/object/object.php
848--------------------------------------------------------------------------------
849FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
850--------------------------------------------------------------------------------
851 18 | ERROR | @since tag comment indented incorrectly; expected 2 spaces but
852 | | found 7
853--------------------------------------------------------------------------------
```ยด
But i'm not 100% sure that this is correct / expexted. I think we should be able to align with spaces here.
If we are deprecating the class, why are we refactoring it? http://issues.joomla.org/tracker/joomla-cms/4909 ???
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4910.
Because, as George said already it will still be in use some years and it makes sense to make it testable.
Stupid typo's at 2am grumbles
Tests pass now!
| Milestone |
Added: |
||
Merged into 3.4-dev. Thanks!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-24 13:25:06 |
Funny - I thought this was already deprecated - guess marking it deprecated is a wise idea. Good catch.