Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#48769] - [7.0] Remove squizlabs/php_codesniffer dev dependency

Composer Dependency Changed PR-7.0-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
4 Nov 2026
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

As we use only friendsofphp/php-cs-fixer for code style checks of PHP files since #47936, this pr removes the unused development dependency squizlabs/php_codesniffer.

avatar laoneo laoneo - open - 4 Nov 2026
avatar laoneo laoneo - change - 4 Nov 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Nov 2026
Category ⇒ Repository External Library Composer Change
avatar laoneo laoneo - change - 4 Nov 2026
Labels Added: Composer Dependency Changed PR-7.0-dev
avatar tecpromotion
tecpromotion - comment - 4 Nov 2026

The removal itself works on a fresh 7.0-dev instance (ab25d77172): composer install from the lock, composer validate OK, no squizlabs in vendor, composer csfixer runs, site and admin load.

One leftover: the phpcs script in composer.json still points to the removed tool and ruleset, so composer phpcs now fails with ./libraries/vendor/bin/phpcs: not found (exit 127). build/build.php also still lists 'ruleset.xml' in $doNotPackage. Removing both keeps the lock valid (scripts aren't part of the content hash):

--- a/composer.json
+++ b/composer.json
@@ -132,7 +132,6 @@
     "post-install-cmd": [
     "php build/update_fido_cache.php"
     ],
-    "phpcs": "./libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .",
     "csfixer": "./libraries/vendor/bin/php-cs-fixer fix -vvv --dry-run --diff"
   }
 }
--- a/build/build.php
+++ b/build/build.php
@@ -463,7 +463,6 @@ $doNotPackage = [
     'plugins/sampledata/testing/testing.xml',
     'README.md',
     'renovate.json',
-    'ruleset.xml',
     'tests',
 ];
avatar laoneo
laoneo - comment - 4 Nov 2026

thanks, fixed it

Add a Comment

Login with GitHub to post a comment