[#48760] - [6.2] when checked-out indicator is informational.[a11y]
- Ready to Commit
- Medium
- Build: 6.2-dev
- # 48760
- Diff
- brianteeman:module_checked_out
User tests: Successful: Unsuccessful:
Pull Request resolves #48409 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Make disabled grid action tooltips keyboard-accessible by adding tabindex="0" to the informational span generated by JGrid::action().
When a grid action is disabled, Joomla renders it as a <span> rather than an interactive element.
Although the span has an aria-labelledby attribute referencing its tooltip, it is not keyboard-focusable. Consequently, users navigating with a keyboard cannot reach the element or access its tooltip.
This is particularly noticeable in administrator modules such as Popular Articles, where the checked-out indicator displays additional information about the user who has checked out an article and when it was checked out.
The equivalent indicator in the Articles list is keyboard-accessible because it is rendered as an anchor.
Testing Instructions
Make sure you have at least one checked out article
In the article manager you can use the keyboard to navigate to the checked out icon to display the tooltip
Repeat the same in the Popular Articles module on the admin dashboard
Actual result BEFORE applying this Pull Request
The checked out icon can not be reached with the keyboard
Expected result AFTER applying this Pull Request
The checked out icon can be reached with the keyboard
keyviz_alac8lpgoC.mp4
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
richard67
- 
I have tested this item ✅ successfully on 0b9003b
Before the patch the lock icon in Popular Articles and Recently Added Articles could not be reached with Tab. After the patch it gets focus and the tooltip shows who checked the article out and when. The same now works for other disabled grid icons with a tooltip, e.g. the Enabled icon in your own row in Users ("You can't block yourself.").
Hover still works. The check-in link in the Articles list is unchanged.
Suggestion: axe still reports aria-prohibited-attr (serious) on the span: aria-labelledby is not allowed on a span without a role. The remediation in #48409 mentions the same. A role, e.g. role="img", fixes it, and the name stays "Checked out …".
Escape doesn't hide the tooltip, neither on the new tab stop nor on the check-in link in the Articles list (same tooltip CSS). That, the MFA "Default" star and frontend editing from #48409 are not touched here, so "resolves" would close the issue with those still open.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48760.
I have tested this item ✅ successfully on 0b9003b
Before the patch the lock icon in Popular Articles and Recently Added Articles could not be reached with Tab. After the patch it gets focus and the tooltip shows who checked the article out and when. The same now works for other disabled grid icons with a tooltip, e.g. the Enabled icon in your own row in Users ("You can't block yourself.").
Hover still works. The check-in link in the Articles list is unchanged.
Suggestion: axe still reports aria-prohibited-attr (serious) on the span: aria-labelledby is not allowed on a span without a role. The remediation in #48409 mentions the same. A role, e.g. role="img", fixes it, and the name stays "Checked out …".
Escape doesn't hide the tooltip, neither on the new tab stop nor on the check-in link in the Articles list (same tooltip CSS). That, the MFA "Default" star and frontend editing from #48409 are not touched here, so "resolves" would close the issue with those still open.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48760.
Thanks for the test - i consider the "escape does not close the tooltip" to be out of scope for this PR as its a bigger issue
I have tested this item ✅ successfully on 0b9003b
I have tested this PR fix. It does what it says :) - Thank you @brianteeman.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48760.
I have tested this item ✅ successfully on 0b9003b
I have tested this PR fix. It does what it says :) - Thank you @brianteeman.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48760.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
a11y
PR-6.2-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48760.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48760.
I have tested this item ✅ successfully on 0b9003b
Before the patch the lock icon in Popular Articles and Recently Added Articles could not be reached with Tab. After the patch it gets focus and the tooltip shows who checked the article out and when. The same now works for other disabled grid icons with a tooltip, e.g. the Enabled icon in your own row in Users ("You can't block yourself.").
Hover still works. The check-in link in the Articles list is unchanged.
Suggestion: axe still reports
aria-prohibited-attr(serious) on the span:aria-labelledbyis not allowed on a span without a role. The remediation in #48409 mentions the same. A role, e.g.role="img", fixes it, and the name stays "Checked out …".Escape doesn't hide the tooltip, neither on the new tab stop nor on the check-in link in the Articles list (same tooltip CSS). That, the MFA "Default" star and frontend editing from #48409 are not touched here, so "resolves" would close the issue with those still open.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48760.