Composer Dependency Changed PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
1 Nov 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

This pull request (PR) updates the composer development dependencies "phpstan/phpstan" and "phpstan/phpstan-deprecation-rules" to the same versions as currently used in the 6.2-dev branch.

Reason: Currently the "Run PHPstan" action fails in our CI workflow with 3 errors "Call to deprecated method getError() of class Joomla\CMS\MVC\Model\BaseModel".

They are not new, nothing has been changed in the corresponding code, but they were not reported before.

When you add them to the "phpstan-baseline.neon" file, the CI action passes, but then the CI action removes the new entries from the baseline file with the "Updated PHPStan baseline [skip ci]" commit.

You can see that in my closed PR: https://github.com/joomla/joomla-cms/pull/48744/commits

I have not found any explanation for that, no mistake in my opinion in the ci.yml.

In 6.2-dev this does not happen with their newer versions of the phpstan dependencies.

Therefore this PR here to fix that issue.

I could also have updated the 2 dependencies to meanwhile available newer versions, but then we have to do the same in the 6.2-dev and upper branches, too, so they won't have a downgrade.

I've decided against that and think if we do that, we should do it with a separate PR.

Testing Instructions

Check the "Run PHPstan" action of our CI workflow.

Actual result BEFORE applying this Pull Request

Fails for the last commit of the 5.4-dev branch, see https://github.com/joomla/joomla-cms/actions/runs/41334221346/job/124963875630

Expected result AFTER applying this Pull Request

Succeeds for this PR here, see https://github.com/richard67/joomla-cms/actions/runs/41346881868/job/124968902675

No additional commit "Updated PHPStan baseline [skip ci]" is created for this PR here, see ... (link will be added soon)

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 1 Nov 2026
avatar richard67 richard67 - change - 1 Nov 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2026
Category ⇒ External Library Composer Change
avatar richard67 richard67 - change - 1 Nov 2026
The description was changed
avatar richard67 richard67 - edited - 1 Nov 2026
avatar richard67 richard67 - change - 2 Nov 2026
Labels Added: Composer Dependency Changed PR-5.4-dev
avatar richard67 richard67 - change - 2 Nov 2026
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-11-02 15:30:48
Closed_By ⇒ richard67
avatar richard67 richard67 - close - 2 Nov 2026
avatar richard67 richard67 - change - 2 Nov 2026
Status Closed ⇒ New
Closed_Date 2026-11-02 15:30:48 ⇒
Closed_By richard67 ⇒
avatar richard67 richard67 - change - 2 Nov 2026
Status New ⇒ Pending
avatar richard67 richard67 - reopen - 2 Nov 2026
avatar muhme muhme - close - 3 Nov 2026
avatar muhme muhme - merge - 3 Nov 2026
avatar muhme muhme - change - 3 Nov 2026
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-11-03 07:38:55
Closed_By ⇒ muhme
avatar muhme
muhme - comment - 3 Nov 2026

Thank you very much @richard67 for your contribution. Thank you @tecpromotion for review.

Add a Comment

Login with GitHub to post a comment