User tests: Successful: Unsuccessful:
Pull Request resolves #48404 .
Three functional/informative icons in the Atum administrator template were below the WCAG 2.2 SC 1.4.11 (Non-text Contrast) minimum of 3:1. Each is fixed separately (SCSS only, no PHP/JS changes):
blocks/_shepard-modals.scss): the icon used Shepherd's default hsla(0,0%,50%,.75) on the rgb(230,230,230) header in light mode. It now uses an opaque #6c6c6c, and hover/keyboard focus use black. Dark mode is unchanged.vendor/choicesjs/choices.scss): the default state used opacity: .5, now opacity: .75. Hover/focus (opacity 1) and the focus treatment are unchanged. This applies to every Choices.js remove button in Atum.pages/_com_users.scss): the star used .text-warning (rgb(255,181,20)) on a near-white card. In light mode it now uses #b07a00. Dark mode keeps the original yellow.Measured contrast (light mode, after alpha/opacity compositing):
| Icon | Before | After |
|---|---|---|
| Guided Tours cancel X | 2.27:1 | 4.21:1 |
| Category remove × | ~3.1:1 | ~6.4:1 |
| MFA default star | 1.72:1 | 3.63:1 |
Notes:
administrator/components/com_users/tmpl/methods/list.php, so it covers every MFA method marked as default.choices.scss and the site com_users methods template). They are not part of this issue and are not changed here.Apply the PR and run npm ci && npm run build so the Atum CSS is rebuilt. Use Atum in light mode, then repeat in dark mode.
Measure the icon colour against its background with any contrast checker. Also try a narrow viewport (about 640px wide, equivalent to 200% zoom).
In light mode:
rgba(128,128,128,.75) on #e6e6e6, about 2.27:1.default star: rgb(255,181,20) on a near-white card, about 1.72:1.
![]()
![]()
In light mode all three icons are at least 3:1 in their default state:
Dark mode, hover, keyboard focus and the narrow viewport behave as before or better. Checked in Firefox and Chrome (computed values).
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Layout Libraries |
| Title |
|
||||||
@exlemor thanks for testing, and @brianteeman thanks for the explanation.
Manager inherits Edit State = Allowed from Global Configuration, so it has to be explicitly set to Denied to reproduce:
I have tested this item ✅ successfully on 54917f1
Hi @Nikhil-sinhaa - thanks to Brian and your explanation, I was able to test this successfully. Teamwork makes for easier work ;)
Thank you for the PR fix!
I have tested this item ✅ successfully on 54917f1
Hi @Nikhil-sinhaa - thanks to Brian and your explanation, I was able to test this successfully. Teamwork makes for easier work ;)
Thank you for the PR fix!
@Nikhil-sinhaa - I am trying to test your PR unfortunately, I am unable to match the BEFORE condition, I followed your steps but when I log in as Manager, (and I checked I was manager and Edit state: Denied), I am able to unfeature, and unpublish the articles... i.e. the buttons are NOT disabled :/
?! I can attach a video if need be but I double checked the steps.