User tests: Successful: Unsuccessful:
Pull Request resolves #48704 .
administrator/components/com_config/tmpl/component/default.php builds $dataShowOn for a fieldset that has a showon attribute and loads the showon script, but the attribute was never printed on the <fieldset> element (the output was lost when Global Configuration moved to custom-element tabs in 4.0). This PR outputs it on both fieldset tags, so showon on a fieldset in a component's config.xml works again.
administrator/components/com_users/config.xml and, inside the integration fieldset, add a second child fieldset after integration_customfields:<fieldset name="integration_test" label="Test showon fieldset" showon="custom_fields_enable:1">
<field name="test_text" type="text" label="Test text" />
</fieldset>The added fieldset is a dummy for testing only. "Edit Custom Fields" is used just as an existing Yes/No field for its showon to depend on; its own behaviour is not changed by this PR.
The "Test showon fieldset" fieldset is always shown. The <fieldset id="fieldset-integration_test"> element has no data-showon attribute.
The "Test showon fieldset" fieldset (including its legend) is hidden when "Edit Custom Fields" is No and shown when it is Yes. Fieldsets without showon are unchanged.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_config |
| Labels |
Added:
PR-6.2-dev
|
||
I think you have misunderstood the purpose of the option "edit custom fields". It does not control the display of custom fields. It controls whether the menu options for fields and field groups are displayed and therefore if new fields can be added etc
Or I have misunderstood you
Sorry, my testing instructions weren't clear. The PR doesn't change anything about custom fields or what "Edit Custom Fields" does.
No, the PR doesn't change anything about custom fields. I just used that switch in the test because it's an existing Yes/No field on the same tab. The test fieldset is a dummy, any field would work.
The actual bug is that showon on a fieldset in a component's config.xml doesn't work, because the data-showon attribute is never printed. Without the PR the dummy fieldset is always shown, with the PR it hides/shows with the switch.
Thanks for clarifying. I had indeed misunderstood
| Title |
|
||||||
I have tested this item ✅ successfully on 57d80bf
I have tested this item ✅ successfully on 57d80bf
I have tested this item ✅ successfully on 57d80bf
Test okay since code changes already tested on #48704
I have tested this item ✅ successfully on 57d80bf
Test okay since code changes already tested on #48704
| Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-11-06 17:08:57 |
| Closed_By | ⇒ | MacJoom |
Thank you!
I think you have misunderstood the purpose of the option "edit custom fields". It does not control the display of custom fields. It controls whether the menu options for fields and field groups are displayed and therefore if new fields can be added etc