[#48717] - [6.2] Admin modules drop down menu [rtl]
- Pending
- Medium
- Build: 6.2-dev
- # 48717
- Diff
- brianteeman:dropdown_rtl
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Remove the language direction check to change the css class
Originally we manually created the rtl template css - but instead of correcting the css in the rtl template we changed the class. Later I changed the way we generate the RTL css to use a post processor. This converted all the left to right etc so we didnt need to change the class used here. My fault I missed it when I did the conversion.
This PR removes the isRTL check and the change in class as it is not needed
Bonus it removes some deprecated code
Testing Instructions
Install an RTL language and then using that RTL labguage in the Joomla admin go to the home dashboard and check the display of the dropdown on the module cog
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I have tested this item ✅ successfully on 7411757
I was able to test this successfully. Thanks @brianteeman.
For other testers: I initially received the message in red: The file marked for modification does not exist: phpstan-baseline.neon when trying to use the Joomla Patch Tester but I then Downloaded the Update package and was able to test successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48717.
I have tested this item 🔴 unsuccessfully on 7411757
Verdict: needs changes. The RTL fix works; one unintended a11y regression in body.php.
Finding
chromes/body.php also removes the visually-hidden label of the cog button. The icon is aria-hidden, so the button now has no accessible name (well.php keeps it):
| Accessible name of the cog button | before | after |
|---|---|---|
well chrome (dashboard) |
"Edit the 'Popular Articles' module" | unchanged |
body chrome |
"Edit the 'Logged-in Users' module" | (empty), en-GB and ar-AA |
Fix: keep this line in body.php:
<span class="visually-hidden"><?php echo Text::sprintf('JACTION_EDIT_MODULE', $module->title); ?></span>Verification (RTL part)
6.2-dev, Arabic language pack (ar-AA 6.1.4.1) as admin language, home dashboard, cog of "Popular Articles" (well) and of "Logged-in Users" set to Module Style atum-body:
ar-AA, well chrome |
before | after |
|---|---|---|
| menu | opens outwards over the neighbouring card; in the left column off-screen (left: -90px, horizontal page scroll) |
opens inside the card |
en-GB: menu position unchanged. phpstan (with the updated baseline) and php-cs-fixer clean.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48717.
I have tested this item 🔴 unsuccessfully on 7411757
Verdict: needs changes. The RTL fix works; one unintended a11y regression in body.php.
Finding
chromes/body.php also removes the visually-hidden label of the cog button. The icon is aria-hidden, so the button now has no accessible name (well.php keeps it):
| Accessible name of the cog button | before | after |
|---|---|---|
well chrome (dashboard) |
"Edit the 'Popular Articles' module" | unchanged |
body chrome |
"Edit the 'Logged-in Users' module" | (empty), en-GB and ar-AA |
Fix: keep this line in body.php:
<span class="visually-hidden"><?php echo Text::sprintf('JACTION_EDIT_MODULE', $module->title); ?></span>Verification (RTL part)
6.2-dev, Arabic language pack (ar-AA 6.1.4.1) as admin language, home dashboard, cog of "Popular Articles" (well) and of "Logged-in Users" set to Module Style atum-body:
ar-AA, well chrome |
before | after |
|---|---|---|
| menu | opens outwards over the neighbouring card; in the left column off-screen (left: -90px, horizontal page scroll) |
opens inside the card |
en-GB: menu position unchanged. phpstan (with the updated baseline) and php-cs-fixer clean.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48717.
Oops that was an error
| Labels |
Added:
PR-6.2-dev
|
||
I have tested this item ✅ successfully on 7411757
I was able to test this successfully. Thanks @brianteeman.
For other testers: I initially received the message in red: The file marked for modification does not exist: phpstan-baseline.neon when trying to use the Joomla Patch Tester but I then Downloaded the Update package and was able to test successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48717.