[#48714] - [6.2] Fix 4 issues in "list all tags"
- Pending
- Medium
- Build: 6.2-dev
- # 48714
- Diff
- chmst:6.2/Fix-all-tags-layout
User tests: Successful: Unsuccessful:
Pull Request resolves #48611.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This PR resolves 4 issues in "list all tags" layout:
- All list items have <h3 tag
- The Number of columns is ignored.
- The layout breaks when filter is not displayed but listlimit is displayed.
- If listlimit box is displayed, the maximum number of items to be displayed is ignored.
The PR changes:
- ul around every tag and H3 tag are removed. There is no reason for a heading tag and this is often a a11y issue in the order of headings.
- [AI assisted] Use an inline style to transfer the column number to the css column.
- Fix the HTML
- Change in the config file. The maximum number is only visible if the limit box is disabledd.
Testing Instructions
Make a number of tasks.
Make a menu item "List all Tags"
Try different options - enable / disable filter and enable / disable list-limit.
Set the maximum items to display when the listLimit box is enabled disabled
Actual result BEFORE applying this Pull Request
Example
Expected result AFTER applying this Pull Request
Example with 3 columns,
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End NPM Change |
Hi @chmst, I was testing this for you and while this fixes a bunch of things - THANK YOU, that's great!, something seems still off...
On my screen as it appears on your screenshots, I see an issue - PERHAPS out of this scope but if it is, I think it would be important to mention it for testers?
Left-hand most column element 48714-1 selected:
You'll notice no .list-group-item+.list-group-item {
border-top-width: 0;} css for that column yet...
Middle column element 48714-2 selected:
includes the .list-group-item+.list-group-item {
border-top-width: 0;} which makes the element have no top border and look off by 1 pixel for middle and right-hand most column...
Also, changes the height values as highlighted in red by 1 pixel.
Hope that is clear, looking forward to your reply so that I can make the test successful if this is out-of-scope?
Hi @chmst, I was testing this for you and while this fixes a bunch of things - THANK YOU, that's great!, something seems still off...
On my screen as it appears on your screenshots, I see an issue - PERHAPS out of this scope but if it is, I think it would be important to mention it for testers?
Left-hand most column element 48714-1 selected:
You'll notice no .list-group-item+.list-group-item {
border-top-width: 0;} css for that column yet...
Middle column element 48714-2 selected:
includes the .list-group-item+.list-group-item {
border-top-width: 0;} which makes the element have no top border and look off by 1 pixel for middle and right-hand most column...
Also, changes the height values as highlighted in red by 1 pixel.
Hope that is clear, looking forward to your reply so that I can make the test successful if this is out-of-scope?
Hi @chmst, I was testing this for you and while this fixes a bunch of things - THANK YOU, that's great!, something seems still off...
On my screen as it appears on your screenshots, I see an issue - PERHAPS out of this scope but if it is, I think it would be important to mention it for testers?
Left-hand most column element 48714-1 selected:
You'll notice no .list-group-item+.list-group-item {
border-top-width: 0;} css for that column yet...
Middle column element 48714-2 selected:
includes the .list-group-item+.list-group-item {
border-top-width: 0;} which makes the element have no top border and look off by 1 pixel for middle and right-hand most column...
Also, changes the height values as highlighted in red by 1 pixel.
Hope that is clear, looking forward to your reply so that I can make the test successful if this is out-of-scope?
Thank you for your test, very appreciated. Will check this right now and think it needs to be fixed here.
Thank you for your test, very appreciated. Will check this right now and think it needs to be fixed here.
Glad I can help in my own little way.
| Labels |
Added:
NPM Resource Changed
bug
PR-6.2-dev
|
||
I made a little change, so that all list items have a border.
By default listItems, except the first one, have no border-top. When the list is ivide, then the border-top is missing.
I made a little change, so that all list items have a border.
By default listItems, except the first one, have no border-top. When the list is divided, then the border-top is missing.
- We really should avoid using inline styles
- I am not seeing any borders. When I inspect the class it says this is because the variables are not defined
Thank you @brianteeman for testing. Strange enough my previuos test was ok, maybe from cache?
This looks ok in my application
About inline style: I will be happy to accept any better solution but could not find one without generating several lists (UL).
Currently there are multiple lists so unless you have strong feelings against that it can be achieved that way
I have tested this item ✅ successfully on 1b2e563
I was able to retest this after the update/fix - thank you @chmst! Looks great now! :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48714.
I have tested this item ✅ successfully on 1b2e563
I was able to retest this after the update/fix - thank you @chmst! Looks great now! :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48714.
Could also go into 6.3 or 7.0.
It fixes errors but users who have own overrides could be surprised.