[#48664] - [6.2] [a11y] Add missing aria-label to quickicon add link button
- Pending
- Medium
- Build: 6.2-dev
- # 48664
- Diff
- SiddheshCodes4554:fix-quickicon-a11y-add-button
User tests: Successful: Unsuccessful:
I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Adds an explicit aria-label to the Quick Icon “Add” link in layouts/joomla/quickicons/icon.php.
The accessible name uses the existing translated *_ADD language string, matching the link's title attribute and providing assistive technologies with a clear description of the link's purpose.
Testing Instructions
- Log in to the Joomla Administrator.
- Open the Home Dashboard.
- Locate a Quick Icon that provides an “Add” action, such as Articles or Categories.
- Inspect the rendered link using browser developer tools.
- Verify that the link has an
aria-labelmatching its translatedtitletext. - Check the link's computed accessible name in the browser's Accessibility panel.
Actual result BEFORE applying this Pull Request
The Quick Icon “Add” link relies on its title attribute for its accessible name, while the child plus icon is marked aria-hidden="true". The link does not have an explicit aria-label.
Expected result AFTER applying this Pull Request
The Quick Icon “Add” link has an explicit, translated aria-label that describes its purpose, improving the clarity and consistency of its accessible name for assistive technology users.
Link to documentations
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
@SiddheshCodes4554 thank you for your contribution.
Could you please change your description so that it matches our usual template? And confoirm the AI policy? Just compare other PR descriptions.
It makes the life of maintainers easier.
@SiddheshCodes4554 thank you for your contribution.
Could you please change your description so that it matches our usual template? And confirm the AI policy? Just compare other PR descriptions.
It makes the life of maintainers easier.
I have tested this item ✅ successfully on d769043
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48664.
I have tested this item ✅ successfully on d769043
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48664.
Thanks for the feedback! I've updated the PR description to follow Joomla's standard template, including the AI policy confirmation, summary of changes, testing instructions, before/after results, and documentation impact. I'll also make sure the AI disclosure follows the project's policy. Thanks for pointing me in the right direction.
I don't know which is better (aria-label vs. visually-hidden), but it probably should be consistent in both instances.
I don't know which is better (
aria-labelvs.visually-hidden), but it probably should be consistent in both instances.
Thanks for pointing this out. I agree that the accessible naming should be consistent across both instances. I'll check the existing Joomla patterns for icon-only links and align the implementation with the preferred approach, whether that's aria-label or visually hidden text.
richard67
- | Title |
|
||||||
| Labels |
Added:
a11y
PR-6.2-dev
|
||
@SiddheshCodes4554 tahnk you for your contribution.
Could you please change your description so that it matches our usual template? And confoirm the AI policy? Just compare other PR descriptions.
It makes the life of maintainers easier.