[#4865] - Fixed JLog class to accept event handler callables objects with closures
- Closed
- 12 Dec 2015
- Medium
- Build: staging
- # 4865
- Diff
- beat:fix-joomla-log-closures-acceptance
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR fixes JLog class as used in the Joomla Debug plugin, to accept callables of type array(object, method) where object has closures.
serialize() of object with closures generates a fatal error in php.
Thus for closures as handlers, this has been fixed already by using spl_object_hash() for the closure. But in case of a handler that is array(object, method) where object might have variables containing closures (or objects containing variables with closures), it is still generating a fatal error.
This PR is obvious with a source-code review. Tests should check that plugins continue to work fine (e.g. remember-me and sef). If desired, a valid test-code that generates a fatal with master, but works fine with PR can be provided.
jissues-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
I have tested this item 
successfully on e9316b8
Plugins Sucessfully tested. Not able to understand code.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4865.
Oh, but wait a second! What if the first value of the array isn't an object instance but a string - that might happen when the callback method can be called statically, right?
| Status | Pending | ⇒ | Information Required |
@SniperSister I understand what you are saying but can't imagine it :) Do you have any code example to visualize it?
Hm. In the meantime I can't imagine it either. And after rechecking the code I think it isn't an issue at all, so forget about it ;)
| Milestone |
Added: |
||
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-12 13:27:48 |
| Closed_By | ⇒ | roland-d |
Looks good to me from a code review perspective.