[#48645] - [6.2] Update currentItem management in Changelog.php
- Ready to Commit
- Medium
- Build: 6.2-dev
- # 48645
- Diff
- alikon:patch-1
User tests: Successful: Unsuccessful:
Refactor currentItem handling in Changelog class.
Pull Request resolves #48392 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
One item one row
Testing Instructions
Create a changelog document containing one whose text has a non-ASCII character — a German umlaut, a French accent, a typographic quote etc
<?xml version="1.0" encoding="UTF-8"?>
<changelogs>
<changelog>
<element>plg_system_example</element>
<type>plugin</type>
<folder>system</folder>
<version>1.0.0</version>
<fix>
<item>Dateien, die außerhalb von Joomla gelöscht wurden, blieben stehen.</item>
</fix>
</changelog>
</changelogs>Host it and point an extension's at it.
Install that extension at version 1.0.0.
Go to System → Manage → Extensions, click the version number to open the changelog modal.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
One list entry
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item ✅ successfully on 4a8730e
| <item> | Before | After |
|---|---|---|
| Dateien, die außerhalb … (issue example) | 2 bullets: Dateien, die au / ßerhalb … | 1 bullet |
| Tom & Jerry – „…“ and café | 4 bullets: Tom / & / Jerry / – „…“ | 1 bullet |
| multi-line item with ä | 2 bullets | 1 bullet |
| plain ASCII, CDATA with HTML | 1 bullet | 1 bullet (unchanged) |
| <item></item> | not shown | not shown |
Note: the "Actual result BEFORE" section in the description is empty; the before state is as shown above.
Nit (optional): private string $currentItem = ''; (typed property).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48645.
I have tested this item ✅ successfully on 4a8730e
<item> |
Before | After |
|---|---|---|
Dateien, die außerhalb … (issue example) |
2 bullets: Dateien, die au / ßerhalb … |
1 bullet |
Tom & Jerry – „…“ and café |
4 bullets: Tom / & / Jerry / – „…“ |
1 bullet |
multi-line item with ä |
2 bullets | 1 bullet |
| plain ASCII, CDATA with HTML | 1 bullet | 1 bullet (unchanged) |
<item></item> |
not shown | not shown |
Note: the "Actual result BEFORE" section in the description is empty; the before state is as shown above.
Nit (optional): private string $currentItem = ''; (typed property).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48645.
I have tested this item ✅ successfully on 4a8730e
| | Before | After |
|---|---|---|
| Dateien, die außerhalb … (issue example) | 2 bullets: Dateien, die au / ßerhalb … | 1 bullet |
| Tom & Jerry – „…“ and café | 4 bullets: Tom / & / Jerry / – „…“ | 1 bullet |
| multi-line item with ä | 2 bullets | 1 bullet |
| plain ASCII, CDATA with HTML | 1 bullet | 1 bullet (unchanged) |
| | not shown | not shown |
Note: the "Actual result BEFORE" section in the description is empty; the before state is as shown above.
Nit (optional): private string $currentItem = ''; (typed property).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48645.
I have tested this item ✅ successfully on 4a8730e
| | Before | After |
|---|---|---|
| Dateien, die außerhalb … (issue example) | 2 bullets: Dateien, die au / ßerhalb … | 1 bullet |
| Tom & Jerry – „…“ and café | 4 bullets: Tom / & / Jerry / – „…“ | 1 bullet |
| multi-line item with ä | 2 bullets | 1 bullet |
| plain ASCII, CDATA with HTML | 1 bullet | 1 bullet (unchanged) |
| | not shown | not shown |
Note: the "Actual result BEFORE" section in the description is empty; the before state is as shown above.
Nit (optional): private string $currentItem = ''; (typed property).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48645.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48645.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48645.
I have tested this item ✅ successfully on 4a8730e
|
<item>| Before | After ||---|---|---|
|
Dateien, die außerhalb …(issue example) | 2 bullets:Dateien, die au/ßerhalb …| 1 bullet ||
Tom & Jerry – „…“ and café| 4 bullets:Tom/&/Jerry/– „…“| 1 bullet || multi-line item with
ä| 2 bullets | 1 bullet || plain ASCII, CDATA with HTML | 1 bullet | 1 bullet (unchanged) |
|
<item></item>| not shown | not shown |Note: the "Actual result BEFORE" section in the description is empty; the before state is as shown above.
Nit (optional):
private string $currentItem = '';(typed property).This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48645.