@dirk-graetz

<?php echo str_replace('&', '&', $uri); ?>

Really?

With this code you change nothing, $search and $replace are the same :D

mixed str_replace ( mixed $search , mixed $replace , mixed $subject [, int &$count ] )
http://php.net/manual/de/function.str-replace.php

Also why you want to echo it?

I think you mean somthing like this? Or i missunderstand you?

<?php str_replace('&', '&amp;', $uri); ?>

You are correct, i copied the text from the old tracker and the code was modified - replace with '&' is right!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4862.

Same again! Your code is right!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4862.

But echo is correct!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4862.

Ok. So @dirk-graetz can you submit a PR aginst staging to fix the issue? Thanks.

See: http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
Review: https://github.com/joomla/joomla-cms/blob/staging/CONTRIBUTING.md

But echo is correct!

Yes but please use two lines. (see my edit) i think it is easyer to understand.

Sorry, i never made that.
And if the original feed-URL ist correctly escaped, my solution in line 104 will (like the original code in line 66) cause an error. Because the result will be &amp
Maybe this should be solved more intelligent...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4862.

@dirk-graetz can you test

preg_replace('/&(?!amp;)/', '&', $uri);

@dirk-graetz see here for a PR: #4863

You can test it using the com_patchtester:
http://docs.joomla.org/Component_Patchtester_for_Testers
https://github.com/joomla-extensions/patchtester/releases/download/2.0.beta/com_patchtester.zip

So I'm closing here as we have a PR to fix it.

Thanks

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/4862

Works great, thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4862.

thanks @dirk-graetz So please comment on http://issues.joomla.org/tracker/joomla-cms/4863 and add your test result there.