[#48585] - [6.2] checking locked items in the Multiligual Associations list
- Pending
- Medium
- Build: 6.2-dev
- # 48585
- Diff
- brianteeman:checkin
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request resolves #41308 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Add the missing form controls required by the Multilingual Associations check-in action.
The Associations view was missing the grid.id checkbox and boxchecked form field required by Joomla.listItemTask(). This prevented the check-in action from submitting the correct item.
Testing Instructions
On a multlingual site
Create an article and check it out by another user, or otherwise ensure the article is locked.
Go to Components → Multilingual Associations.
Select the appropriate item type and language.
Locate the locked article in the Associations view.
Click the lock/check-in icon next to the article.
Actual result BEFORE applying this Pull Request
The lock/check-in icon was displayed, but clicking it did nothing
Expected result AFTER applying this Pull Request
The lock/check-in icon is displayed and clicking it wil check in the article (if you have the required permissions)
If you do not have the required permission then clicking on the lock/check-in icon will give you a message that you cannot checkin
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations |
| Labels |
Added:
PR-6.2-dev
|
||
I can't imagine how the changes in this pr could possibly create those issues. Please test without this pr
Hi again, when I do NOT have the PR fix installed, I get what you point to which is that the lock icon doesn't do anything.
Unsure how I should test this beyond that, I can do a video if that would help.
sorry - just checked again and you are correct
found it - please test again
Hi @brianteeman, so now when logging in as a Super User, I do get the You can't check-in this item (in a red background which makes sense). Is that a valid PR test for the scope of this PR?
1 small question remains in my mind, why wouldn't a Super User be able to check in that Multi-lingual Association? and who could (/what special permissions would make that possible)?
I have tested this item ✅ successfully on f09a3d8
I tested it, and everything is working fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48585.
I have tested this item ✅ successfully on f09a3d8
I tested it, and everything is working fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48585.
@brianteeman - Thank you for this PR.
Standard Joomla 6.2 RC3 nightly build from yesterday. Only things installed: Joomla Patch Tester and RegularLabs CacheCleaner.
I found a couple of small things and before I invalidate the test, I prefer checking with you if it's out of scope of the PR or not...
I created an article as a backend administrator and tried Check-In as a Super User yet I received a "You can't check in this item" message which doesn't seem logical to me. Shouldn't the Super User be able to check-in anything created by an Administrator?
The background color of the error message "You can't check in this item" is green - green seems the wrong color here - as it implies 'everything is good/fine', it should at least be orange if not red, no?