[#48578] - [6.2] spaces in image filenames rss
- Ready to Commit
- Medium
- Build: 6.2-dev
- # 48578
- Diff
- brianteeman:spacesrss
User tests: Successful: Unsuccessful:
Pull Request resolves #43742 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Fixes an issue where images with spaces in their filenames could not be resolved when generating image URLs.
HTMLHelper::image() was passing the URL-encoded path directly to the filesystem lookup. For example, banner cradle.jpg was received as banner%20cradle.jpg, causing the filesystem lookup to fail because the actual filename contains a space.
The path is now decoded for the filesystem lookup while spaces are encoded again in the resulting URL. This allows images containing spaces in their filenames to be correctly displayed while preserving the URL encoding required by browsers and RSS feeds.
Testing Instructions
- Create or use an image whose filename contains a space, for example
banner cradle.jpg. - Create an article and set the image as the article's Intro Image.
- Create a category blog menu item that will display the article
- View the article and confirm that the intro image is displayed correctly.
- Open the category RSS feed and confirm that the image is included
Actual result BEFORE applying this Pull Request
the image is missing in the generated rss feed
Expected result AFTER applying this Pull Request
Images containing spaces in their filenames are included in the RSS and contain the correctly encoded %20.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
I have tested this item ✅ successfully on 3cac0f1
Hello @brianteeman, I have tested this successfully even though the image doesn't appear in my RSS feed due to the fact that my Joomla installation is in a sub-folder.. (but in the past, you and I have talked about this being a separate issue so the scope of this PR about the image being rendered in the RSS feed works after your fix)
Thank you.
Without the PR:
<title>Article PR 48578</title>With the PR:
<title>Article PR 48578</title>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
Hello @brianteeman, I have tested this successfully even though the image doesn't appear in my RSS feed due to the fact that my Joomla installation is in a sub-folder.. (but in the past, you and I have talked about this being a separate issue so the scope of this PR about the image being rendered in the RSS feed works after your fix)
Thank you.
`
Without the PR:
With the PR:
<title>Article PR 48578</title>This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578. `
I have tested this item ✅ successfully on 3cac0f1
Hello @brianteeman, I have tested this successfully even though the image doesn't appear in my RSS feed due to the fact that my Joomla installation is in a sub-folder.. (but in the past, you and I have talked about this being a separate issue so the scope of this PR about the image being rendered in the RSS feed works after your fix)
Thank you.
`Without the PR:
<title>Article PR 48578</title>`With the PR:
<title>Article PR 48578</title>This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.`
I have tested this item ✅ successfully on 3cac0f1
Hello @brianteeman, I have tested this successfully even though the image doesn't appear in my RSS feed due to the fact that my Joomla installation is in a sub-folder.. (but in the past, you and I have talked about this being a separate issue so the scope of this PR about the image being rendered in the RSS feed works after your fix)
Thank you.
Without the PR:
<title>Article PR 48578</title>
With the PR:
<title>Article PR 48578</title>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
Hello @brianteeman, I have tested this successfully even though the image doesn't appear in my RSS feed due to the fact that my Joomla installation is in a sub-folder.. (but in the past, you and I have talked about this being a separate issue so the scope of this PR about the image being rendered in the RSS feed works after your fix)
Thank you.
Without the PR:
<title>Article PR 48578</title>
With the PR:
<title>Article PR 48578</title>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
Hello @brianteeman, I have tested this successfully even though the image doesn't appear in my RSS feed due to the fact that my Joomla installation is in a sub-folder.. (but in the past, you and I have talked about this being a separate issue so the scope of this PR about the image being rendered in the RSS feed works after your fix)
Thank you.
Without the PR:
<title>Article PR 48578</title>
With the PR:
<title>Article PR 48578</title>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
Hello @brianteeman, I have tested this successfully even though the image doesn't appear in my RSS feed due to the fact that my Joomla installation is in a sub-folder.. (but in the past, you and I have talked about this being a separate issue so the scope of this PR about the image being rendered in the RSS feed works after your fix)
Thank you.
Without the PR:
<title>Article PR 48578</title>With the PR:
!DOCTYPE html2>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
I have it tested, the patch works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
I have it tested, the patch works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
tested successfully on 6.2.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
tested successfully on 6.2.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
Tested on the JWC 2026
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
Tested on the JWC 2026
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
At the BUG Squad, tested this as excercise
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
I have tested this item ✅ successfully on 3cac0f1
At the BUG Squad, tested this as excercise
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.
Thanks to all the first time testers here. I hope this is just the first of many
I have tested this item ✅ successfully on 3cac0f1
Hello @brianteeman, I have tested this successfully even though the image doesn't appear in my RSS feed due to the fact that my Joomla installation is in a sub-folder.. (but in the past, you and I have talked about this being a separate issue so the scope of this PR about the image being rendered in the RSS feed works after your fix)
Thank you.
Without the PR:
<title>Article PR 48578</title>With the PR:
<title>Article PR 48578</title>This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48578.