[#48540] - [6.2] tasks filters
- Ready to Commit
- Medium
- Build: 6.2-dev
- # 48540
- Diff
- brianteeman:orphaned
User tests: Successful: Unsuccessful:
Pull Request resolves #36207 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
The search tools filter bar is hidden when the orphaned filter was selected - everywhere else having a filter selected keeps the search toolbar open
Maintainers I believe at the time of writing this is the correct branch for a bugfix but if not I am happy to rebase it
Testing Instructions
Go to System → Scheduled Tasks.
Observe that the search filters are not displayed
Click on filter options and change the status
Observe that the search filters are displayed
Unset the status filter and change the orphaned filter
Observe that the search filters are not displayed
Actual result BEFORE applying this Pull Request
Search filters are never displayed no matter what the setting for the orphaned filter
Expected result AFTER applying this Pull Request
Search filters are displayed as expected
Note The orphaned filter does not have a no-value setting - thats beyond the scope of this PR
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
PR-6.2-dev
|
||
The change is correct, also from a11y point of view, but not sufficient. Now the filter never closes, at any time one of the options is active.
The filter needs a select option:
COM_SCHEDULER_SELECT_ORPHANED
COM_SCHEDULER_OPTION_ORPHANED_HIDE
COM_SCHEDULER_OPTION_ORPHANED_SHOW
COM_SCHEDULER_OPTION_ORPHANED_ONLY
The change is correct, also from a11y point of view, but not sufficient. Now the filter never closes, at any time one of the options is active.
The filter needs a select option:
<field
name="orphaned"
type="list"
label="COM_SCHEDULER_FIELD_LABEL_SHOW_ORPHANED"
default=""
class="js-select-submit-on-change"
>
<option value="">COM_SCHEDULER_SELECT_ORPHANED</option>
<option value="-1">COM_SCHEDULER_OPTION_ORPHANED_HIDE</option>
<option value="0">COM_SCHEDULER_OPTION_ORPHANED_SHOW</option>
<option value="1">COM_SCHEDULER_OPTION_ORPHANED_ONLY</option>
</field>
Note The orphaned filter does not have a no-value setting - thats beyond the scope of this PR
Then the Filter never closes.
I assume it was a design decision that the filter is always set. That's why it's beyond the scope of this pr
I have tested this item 🔴 unsuccessfully on f4bc39d
Tested with JBT
- Before PR
- If orphaned entry is selected the filter closes
- Applied PR with Patch Tester
- If I initial open the view, the filter is closed, which is counted as wrong as one orphaned entry is selected
- If I select orphaned, the filter stands open (improved by PR)
- If I click clear the filter closes, even one orphaned entry is selected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48540.
I have tested this item 🔴 unsuccessfully on f4bc39d
Tested with JBT
- Before PR
- If orphaned entry is selected the filter closes
- Applied PR with Patch Tester
- If I initial open the view, the filter is closed, which is counted as wrong as one orphaned entry is selected
- If I select orphaned, the filter stands open (improved by PR)
- If I click clear the filter closes, even one orphaned entry is selected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48540.
| Category | Administration | ⇒ | Administration Language & Strings |
I have tested this item ✅ successfully on 7e17cff
Tested with JBT (after next commit)
- Before PR
- If orphaned entry is selected the filter closes
- Applied PR with Patch Tester
- If I initial open the view, the filter is closed (as 'Select Orphaned' entry is selected)
- If I select orphaned, the filter stands open
- If I click clear the filter closes
- No unusual PHP or Joomla log messages
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48540.
I have tested this item ✅ successfully on 7e17cff
Tested with JBT (after next commit)
- Before PR
- If orphaned entry is selected the filter closes
- Applied PR with Patch Tester
- If I initial open the view, the filter is closed (as 'Select Orphaned' entry is selected)
- If I select orphaned, the filter stands open
- If I click clear the filter closes
- No unusual PHP or Joomla log messages
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48540.
I have tested this item ✅ successfully on 7e17cff
Tested on a 6.2 RC2 nightly build
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48540.
I have tested this item ✅ successfully on 7e17cff
Tested on a 6.2 RC2 nightly build
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48540.
This has two successful tests please mark as RTC
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48540.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48540.
The change is correct, also from a11y point of view, but not sufficient. Now the filter never closes, at any time ohne of the options is active.
The filter needs a select option:
COM_SCHEDULER_SELECT_ORPHANED
COM_SCHEDULER_OPTION_ORPHANED_HIDE
COM_SCHEDULER_OPTION_ORPHANED_SHOW
COM_SCHEDULER_OPTION_ORPHANED_ONLY