[#48517] - [6.1] User Profile contacts
- Ready to Commit
- Medium
- Build: 6.1-dev
- # 48517
- Diff
- brianteeman:user_profile
User tests: Successful: Unsuccessful:
Pull Request resolves #48501 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
That $profile object is a Joomla TextField instance. In Joomla 6 it does not declare a text property, so PHP 8.2+ treats that assignment as creation of a dynamic property and emits:
Deprecated: Creation of dynamic property Joomla\CMS\Form\Field\TextField::$text is deprecated
Testing Instructions
- Activate User Profile Plugin
- Enter some data for a user
- Create a contact for the user
- Activate the display of the user profile in contacts
- Create a menu item for the contact
- Check the user profile section of the displayed contact
Actual result BEFORE applying this Pull Request
with error reporting set to maximum a deprecated notice is displayed
Expected result AFTER applying this Pull Request
no deprecation notices
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Labels |
Added:
PR-6.1-dev
|
||
Should be ok now
I have tested this item ✅ successfully on 65d8aae
Deprecation message is gone.
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48517.
I have tested this item ✅ successfully on 65d8aae
Deprecation message is gone.
Thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48517.
I have tested this item ✅ successfully on 65d8aae
With "Error Reporting" set to "Maximum", after applying the patch, there are no deprecation notice.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48517.
I have tested this item ✅ successfully on 65d8aae
With "Error Reporting" set to "Maximum", after applying the patch, there are no deprecation notice.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48517.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48517.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48517.
@drmenzelit it is still showing as requested updates by you but they have been resolvedf now
Sorry was too quick to submit a fix. Will update it tonight