PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar hiteshm0
hiteshm0
25 Sep 2026

Pull Request resolves #

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

In default_items.php, when an item is unpublished ($item->core_state == 0), the list element was generated with only the modifier class: <li class="list-group-item-danger">

This change adds the missing base class so that the element renders as:
<li class="list-group-item list-group-item-danger">

Testing Instructions

Go to line line 252 on components/com_tags/src/Model/TagModel.php and temporarily change it to:
$this->setState('tag.state', '0,1'); [ This is necessary to surface unpublished items in the front end tagged items view ]

  1. Create a Tag (e.g. Test Tag) in the administrator backend.
  2. Tag one or more unpublished articles with Test Tag.
  3. Create a menu item pointing to Tags → Tagged Items selecting Test Tag.
  4. Open the tagged items view on the frontend and inspect the
  5. element using browser Developer Tools.

Actual result BEFORE applying this Pull Request

The <li> tag is rendered as: <li class="list-group-item-danger">

image

Expected result AFTER applying this Pull Request

The <li> tag is rendered as: <li class="list-group-item list-group-item-danger">

image

[ Notice the difference in styling ]

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hiteshm0 hiteshm0 - open - 25 Sep 2026
avatar hiteshm0 hiteshm0 - change - 25 Sep 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2026
Category ⇒ com_tags Front End
avatar QuyTon QuyTon - test_item - 27 Sep 2026 - Tested successfully
avatar QuyTon
QuyTon - comment - 27 Sep 2026

I have tested this item ✅ successfully on da15bc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48503.

avatar QuyTon
QuyTon - comment - 27 Sep 2026

I have tested this item ✅ successfully on da15bc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48503.

avatar ChristineWk ChristineWk - test_item - 5 Oct 2026 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 5 Oct 2026

I have tested this item ✅ successfully on da15bc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48503.

avatar ChristineWk
ChristineWk - comment - 5 Oct 2026

I have tested this item ✅ successfully on da15bc7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48503.

avatar richard67
richard67 - comment - 5 Oct 2026

@hiteshm0 Could you please check the check box for the AI policy by editing the PR description and replacing the space by a capital "X" between the "[ ]" brackets to acknowledge that policy? Thanks in advance.

avatar richard67 richard67 - change - 5 Oct 2026
Status Pending ⇒ Ready to Commit
Labels Added: PR-5.4-dev
avatar richard67
richard67 - comment - 5 Oct 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48503.

avatar richard67
richard67 - comment - 5 Oct 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48503.

avatar hiteshm0 hiteshm0 - change - 5 Oct 2026
The description was changed
avatar hiteshm0 hiteshm0 - edited - 5 Oct 2026
avatar hiteshm0
hiteshm0 - comment - 5 Oct 2026

sorry @richard67, forgot about that in a hurry, updated it now.

Add a Comment

Login with GitHub to post a comment