User tests: Successful: Unsuccessful:
Pull Request resolves #
In default_items.php, when an item is unpublished ($item->core_state == 0), the list element was generated with only the modifier class: <li class="list-group-item-danger">
This change adds the missing base class so that the element renders as:
<li class="list-group-item list-group-item-danger">
Go to line line 252 on components/com_tags/src/Model/TagModel.php and temporarily change it to:
$this->setState('tag.state', '0,1'); [ This is necessary to surface unpublished items in the front end tagged items view ]
The <li> tag is rendered as: <li class="list-group-item-danger">
The <li> tag is rendered as: <li class="list-group-item list-group-item-danger">
[ Notice the difference in styling ]
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | com_tags Front End |
I have tested this item ✅ successfully on da15bc7
I have tested this item ✅ successfully on da15bc7
I have tested this item ✅ successfully on da15bc7
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.4-dev
|
||
RTC
RTC
sorry @richard67, forgot about that in a hurry, updated it now.
I have tested this item ✅ successfully on da15bc7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48503.