[#4846] - Fix mod_tags_similar in postgres
- Closed
- 22 Oct 2014
- Medium
- Build: staging
- # 4846
- Diff
- wilsonge:similartags_postgres
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Executive Summary
The similar tags module throws an uncaught SQL exception in postgres breaking any page it's loaded on
Testing Instructions
Install the testing dataset on postgres. The main home page will throw an SQL error. Apply the patch. This error will disappear and the page will render normally.
Things to note
There's an issue with the fact the same page is shown 3 times still in the module - but until I can work out errors with saving articles with tags treat this as a known issue. The fact that mysql with the same articles and associated tags shows 0 articles is just as concerning :P So let's just allow people to navigate on their site first!
Votes
jissues-bot
- | Labels |
Added:
?
|
||
| Priority | Medium | ⇒ | Critical |
Tested and it successfully removes SQL message!
@test
success
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4846.
| Status | Pending | ⇒ | Ready to Commit |
RTC - thanks guys!
Very confusing! Haven't been able to find any documentation on the priority in issues! Old documentation for JC doesn't match. Where can I find the new documentation?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4846.
http://docs.joomla.org/Bug_and_Issue_Tracker_Priority I think this still stands.
| Category | ⇒ | Postgresql |
In that case the correct priority would be low instead of critical. Not being able to use that module doesn't make it critical. I understand the urgency for your situation, but that doesn't make it critical.
From an application point of view I would like the modules to deal with db errors properly and don't consider that an error for the user. It should be logged as an error for the webmaster. But for the user it should present it as nothing found. It definitely shouldn't break the page. Repairing the software bug itself is fine, but with these kind of bugs it shouldn't break your site.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Removed:
?
|
||
Re-tested successfully, no longer showing multiple results.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4846.
brianteeman
- | Priority | Critical | ⇒ | Medium |
Sorry, tried to but failed. Started again from scratch on j336 but to many things failed. Like applying patch with com_patchtester and adding tags. Too tired now, giving up for today.
Adding tags fails again :/ I thought we'd got all that merged into staging :'(
Merged into staging. Thanks all for coding and testing!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-22 09:30:30 |
I'm escalating this to critical as it stops you viewing any frontend page with this module on in postgres.