[#48452] - [6.1] Extensions Install: Upload from File: Associate upload limit with Upload & Install button
- Pending
- Medium
- Build: 6.1-dev
- # 48452
- Diff
- mbeganyi-a11y:File-upload-limit-not-conveyed-(Extension-Installer)
User tests: Successful: Unsuccessful:
Updates the default.php of the Extension Installer to allow assistive technology to receive information about the file upload maximum size without needing to move focus away from the "Upload and Install" button.
Pull Request resolves #48393.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Associates the maximum extension package upload size with the Upload & Install button in the Extensions Install screen so that the maximum upload file size is conveyed to assistive technology without focus needing to move from the button..
The existing maximum upload size text is given an ID and is referenced by the button using aria-describedby.
Testing Instructions
- Log in to the Joomla administrator interface
- Navigate to System → Install → Extensions
- Open the Upload Package File tab
- Confirm the maximum upload-size text remains visibly displayed
- Start a screen reader (NVDA, JAWS, VoiceOver) and focus the Upload & Install button
- Confirm that the maximum upload size information is conveyed to assistive technology without needing to move focus away from the button
Actual result BEFORE applying this Pull Request
- The maximum upload size information is visible on screen, but it is not programmatically associated with the Upload & Install button, and
- A screen reader user can focus the button without the maximum permitted upload size being conveyed.
Expected result AFTER applying this Pull Request
When the Upload & Install button receives focus, a screen reader announces the maximum upload size information in addition to the button label.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
@mbeganyi-a11y please check your work to make sure it does what you think it will do before submitting a PR - this can not do what you intend it to do at all - you can not have tested it
I’ve just had a look at it myself, and @brianteeman is right. The code is neither correct nor tested.
What’s more, it’s actually more of a feature than a bug, which means it belongs in 6.3-dev.
I’d recommend that you close the PR and, if necessary, open a new, tested one for 6.3.
@mbeganyi-a11y yYou made the change for the legacy upload button and not for the usual one. So this is only working in some circumstances.
@mbeganyi-a11y You made the change for the legacy upload button and not for the usual one. So this is only working in some circumstances.
not even sure if that code is ever used anywhere
Look as it is used when upload is in non form context. Seems like a left over from the last century.
And we never have non form upload do we?
And we never have non form upload do we?
It is a hiden area with a form. This old and unused area should be removed from the layout.
the code in this layout and the accompanying JS was for support in browsers that do not support FormData which Joomla no longer supports anyway https://caniuse.com/mdn-api_formdata
I would do a PR to remove this code which will never be used but dont know which version to make it for or if this needs to be deprecated first (which seems pointless but the rules might require it)
the code in this layout and the accompanying JS was for support in browsers that do not support FormData which Joomla no longer supports anyway https://caniuse.com/mdn-api_formdata
I would do a PR to remove this code which will never be used but dont know which version to make it for or if this needs to be deprecated first (which seems pointless but the rules might require it)
I suggest a PR for 6.3. There is no b/c break and deprecation is pointless.
please target 7.0, thanks
ok - I was completely wrong - the code is used.
when you use the install from web option and click on install then this fieldset is displayed and used
thorium_yTivLfO4B0.mp4
SORRY - I was completely wrong - the code is used.
when you use the install from web option and click on install then this fieldset is displayed and used
thorium_yTivLfO4B0.mp4
You know what I never did in the last 12 years? Install from web ^^
OK this is all interesting and I'm glad to have..uh..partially solved something but not what I was aiming to solve.
For the maintainers, what's easiest? Should I relabel this PR and create a new one for the intended fix or can I modify this one with additional commits? I was originally thinking a new branch for the intended issue would be best, but please do let me know.
@mbeganyi-a11y please check your work to make sure it does what you think it will do before submitting a PR - this can not do what you intend it to do at all - you can not have tested it