[#48452] - [6.2] Extensions Install: Upload from File: Associate upload limit with Upload & Install button
- Ready to Commit
- Medium
- Build: 6.1-dev
- # 48452
- Diff
- mbeganyi-a11y:File-upload-limit-not-conveyed-(Extension-Installer)
User tests: Successful: Unsuccessful:
Updates the default.php of the Extension Installer to allow assistive technology to receive information about the file upload maximum size without needing to move focus away from the "Upload and Install" button.
Pull Request resolves #48393.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Associates the maximum extension package upload size with the Upload & Install button in the Extensions Install screen so that the maximum upload file size is conveyed to assistive technology without focus needing to move from the button..
The existing maximum upload size text is given an ID and is referenced by the button using aria-describedby.
Testing Instructions
- Log in to the Joomla administrator interface
- Navigate to System → Install → Extensions
- Open the Upload Package File tab
- Confirm the maximum upload-size text remains visibly displayed
- Start a screen reader (NVDA, JAWS, VoiceOver) and focus the "Or browse for file" button
- Confirm that the maximum upload size information is conveyed to assistive technology without needing to move focus away from the button
Actual result BEFORE applying this Pull Request
- The maximum upload size information is visible on screen, but it is not programmatically associated with the Upload & Install button, and
- A screen reader user can focus the button without the maximum permitted upload size being conveyed.
Expected result AFTER applying this Pull Request
When the Upload & Install button receives focus, a screen reader announces the maximum upload size information in addition to the button label.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
@mbeganyi-a11y please check your work to make sure it does what you think it will do before submitting a PR - this can not do what you intend it to do at all - you can not have tested it
I’ve just had a look at it myself, and @brianteeman is right. The code is neither correct nor tested.
What’s more, it’s actually more of a feature than a bug, which means it belongs in 6.3-dev.
I’d recommend that you close the PR and, if necessary, open a new, tested one for 6.3.
@mbeganyi-a11y yYou made the change for the legacy upload button and not for the usual one. So this is only working in some circumstances.
@mbeganyi-a11y You made the change for the legacy upload button and not for the usual one. So this is only working in some circumstances.
not even sure if that code is ever used anywhere
Look as it is used when upload is in non form context. Seems like a left over from the last century.
And we never have non form upload do we?
And we never have non form upload do we?
It is a hiden area with a form. This old and unused area should be removed from the layout.
the code in this layout and the accompanying JS was for support in browsers that do not support FormData which Joomla no longer supports anyway https://caniuse.com/mdn-api_formdata
I would do a PR to remove this code which will never be used but dont know which version to make it for or if this needs to be deprecated first (which seems pointless but the rules might require it)
the code in this layout and the accompanying JS was for support in browsers that do not support FormData which Joomla no longer supports anyway https://caniuse.com/mdn-api_formdata
I would do a PR to remove this code which will never be used but dont know which version to make it for or if this needs to be deprecated first (which seems pointless but the rules might require it)
the code in this layout and the accompanying JS was for support in browsers that do not support FormData which Joomla no longer supports anyway https://caniuse.com/mdn-api_formdata
I would do a PR to remove this code which will never be used but dont know which version to make it for or if this needs to be deprecated first (which seems pointless but the rules might require it)
I suggest a PR for 6.3. There is no b/c break and deprecation is pointless.
please target 7.0, thanks
ok - I was completely wrong - the code is used.
when you use the install from web option and click on install then this fieldset is displayed and used
thorium_yTivLfO4B0.mp4
SORRY - I was completely wrong - the code is used.
when you use the install from web option and click on install then this fieldset is displayed and used
thorium_yTivLfO4B0.mp4
SORRY - I was completely wrong - the code is used.
when you use the install from web option and click on install then this fieldset is displayed and used
thorium_yTivLfO4B0.mp4
You know what I never did in the last 12 years? Install from web ^^
OK this is all interesting and I'm glad to have...uh...partially solved something but not what I was aiming to solve.
I will amend this PR to include the primary button and not only the one in the sidebar as Brian's video demonstrates.
OK this is all interesting and I'm glad to have..uh..partially solved something but not what I was aiming to solve.
For the maintainers, what's easiest? Should I relabel this PR and create a new one for the intended fix or can I modify this one with additional commits? I was originally thinking a new branch for the intended issue would be best, but please do let me know.
| Labels |
Added:
a11y
PR-6.1-dev
a11y-priority-minor (Low)
|
||
no idea what i was thinking of #48452 (comment) just ignore that comment it was garbage
irrelevant of my mistaken comment @mbeganyi-a11y you still can not have tested this PR as it would have been impossible for you to have tested the hidden form
irrelevant of my mistaken comment @mbeganyi-a11y you still can not have tested this PR as it would have been impossible for you to have tested the changes you have made in the hidden form
In my haste I forgot to revert the initial commit, which I will do now. Thus this PR will only target the intended "Or browse for file" button in the "Upload Package File" tab of the Extension Installer.
I have tested this item ✅ successfully on af181e3
Tested with voice over on mac I can hear the additional information about the upload size.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.
I have tested this item ✅ successfully on af181e3
Tested with voice over on mac I can hear the additional information about the upload size.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.
I have tested this item ✅ successfully on 5b24ce6
Tested Successfully the download size is now in the voiceover. Tested with VoiceOver on a Mac. Thank you for the PR!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.
I have tested this item ✅ successfully on 5b24ce6
Tested Successfully the download size is now in the voiceover. Tested with VoiceOver on a Mac. Thank you for the PR!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.
| Title |
|
||||||
Tested with NVDA ✔️
Tested with Windows Narrator ✖️
That may be a narrator issue not a markup issue. Not all screen readers behave the same - tested with all levels of verbosity but the description is never announced.
I wonder if the button should be changed from "Or browse for file" to just "Browse for file"
It only makes sense to have "or" if you can see and read "Drag and drop file here to upload. Or browse for file"
@brianteeman should we open a new PR/Issue/discussion about the wording, seems to me out of scope of this PR
To me it's all the same problem. Not even sure if the first sentence should be hidden from screen readers.
Tested with NVDA ✔️ Tested with Windows Narrator ✖️ That may be a narrator issue not a markup issue. Not all screen readers behave the same - tested with all levels of verbosity but the description is never announced.
I wonder if the button should be changed from "Or browse for file" to just "Browse for file"
It only makes sense to have "or" if you can see and read "Drag and drop file here to upload. Or browse for file"
Interesting. I tested with Narrator on Windows 10 and got the announcement in Edge, Firefox, and Chrome. Not sure your setup but that's strange. Narrator can be finicky. I'm glad NVDA works though.
Regarding the text change, screen reader users often navigate using the arrow keys, so finding that text above the button isn't impossible. If wanting to change it, moving the "or" from the control to the text preceding the button would be fine. As long as the core meaning of the control isn't affected, we're safe.
Regarding the text change, screen reader users often navigate using the arrow keys, so finding that text above the button isn't impossible
only if they know there is text present
personally I would remove the OR completely as its redundant text
| Labels |
Added:
RTC
PR-6.2-dev
|
||
| Category | Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
Regarding the text change, screen reader users often navigate using the arrow keys, so finding that text above the button isn't impossible
only if they know there is text present
personally I would remove the OR completely as its redundant text
Screen reader users often explore pages using arrow keys as not everything is revealed when pressing only the Tab key.
I've updated the .ini file to remove the word "Or". This is an English-only change, and given that I'm not intimately familiar with the translation workflow, I'm hoping this is sufficient to cover other languages as well. Please advise if I'm mistaken.
tested again with windows narrator and it still doesnt announce the aria-described by
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.
tested again with windows narrator and it still doesnt announce the aria-described by
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48452.
| Labels |
Added:
Language Change
Removed: PR-6.1-dev |
||
@mbeganyi-a11y please check your work to make sure it does what you think it will do before submitting a PR - this can not do what you intend it to do at all - you can not have tested it